doc:update contributing md for internal developers #5250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-guomingz
added
the
Doc
|
/bot skip --comment "docs only" |
nv-guomingz
force-pushed
the
user/guomingz/update_contributing_md
branch
from
3c8461d to
e3c3613
Compare
|
PR_Github #9048 [ skip ] triggered by Bot |
|
PR_Github #9048 [ skip ] completed with state |
There was a problem hiding this comment.
Pull Request Overview
Updates CONTRIBUTING.md to strengthen internal developer workflows post-mortem of release delay by enforcing ID tagging, branch targeting, and release-blocker labeling.
- Require JIRA/NVBUG IDs in PR titles and provide NVIDIAN-only examples
- Add guidance for submitting fixes to dedicated branches via NVBUG keywords
- Introduce “release blocker” label requirement for delay-critical PRs
Comments suppressed due to low confidence (3)
CONTRIBUTING.md:114
- [nitpick] The placement of the commit type
[fix]after the NVBUG ID differs from earlier examples; consider standardizing the format across all title examples for consistency.
* [nvbug/5334370][fix] Fix one model EAGLE3 (**NVIDIAN only**)
CONTRIBUTING.md:129
- [nitpick] The term
nvbug **kw** fieldis ambiguous; clarify which keyword field in the NVBUG system this refers to or rephrase for better clarity.
**kw** field. For example, if a bug is reported on the release/v0.20 branch, please submit the fix to
CONTRIBUTING.md:132
- [nitpick] It may be helpful to link to or define the
release blockerlabel (e.g., in a label glossary) so contributors know where to find it and when to apply it.
Meanwhile, please add the "release blocker" label to any PRs that could potentially cause a release delay.
kaiyux
approved these changes
Jun 18, 2025
nv-guomingz
force-pushed
the
user/guomingz/update_contributing_md
branch
from
e3c3613 to
6a219f6
Compare
juney-nvidia
approved these changes
Jun 18, 2025
nv-guomingz
force-pushed
the
user/guomingz/update_contributing_md
branch
from
6a219f6 to
f9d306a
Compare
|
/bot reuse-pipeline |
|
PR_Github #9317 [ reuse-pipeline ] triggered by Bot |
|
PR_Github #9317 [ reuse-pipeline ] completed with state |
nv-guomingz
force-pushed
the
user/guomingz/update_contributing_md
branch
2 times, most recently
from
76f482b to
d78bdab
Compare
|
/bot skip --comment "docs only" |
Signed-off-by: nv-guomingz <[email protected]>
nv-guomingz
force-pushed
the
user/guomingz/update_contributing_md
branch
from
d78bdab to
a8bf024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR for 0.20 post-mortem of release delay