fix: remove cudaStreamSynchronize when using relaxed acceptance #5262
Conversation
yweng0828
force-pushed
the
user/yweng/fix_relaxed_acceptance_copy_sync
branch
from
41bb5f6 to
3445f81
Compare
📝 Walkthrough""" WalkthroughThe changes modify the zeroing of elements in the CUDA tensor Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
yweng0828
changed the title
yweng0828
changed the title
|
/bot run |
yweng0828
changed the title
|
PR_Github #12876 [ run ] triggered by Bot |
|
PR_Github #12876 [ run ] completed with state |
yweng0828
force-pushed
the
user/yweng/fix_relaxed_acceptance_copy_sync
branch
from
2cc5d52 to
e39b152
Compare
|
/bot run |
|
PR_Github #12921 [ run ] triggered by Bot |
|
PR_Github #12921 [ run ] completed with state |
|
/bot run |
|
PR_Github #12988 [ run ] triggered by Bot |
|
PR_Github #12988 [ run ] completed with state |
Signed-off-by: Yue Weng <[email protected]>
Signed-off-by: Yue Weng <[email protected]>
yweng0828
force-pushed
the
user/yweng/fix_relaxed_acceptance_copy_sync
branch
from
e39b152 to
64b995d
Compare
|
/bot run |
|
PR_Github #13095 [ run ] triggered by Bot |
|
PR_Github #13095 [ run ] completed with state |
|
/bot run |
|
PR_Github #13098 [ run ] triggered by Bot |
|
PR_Github #13098 [ run ] completed with state |
…IA#5262) Signed-off-by: Yue Weng <[email protected]> Signed-off-by: Shreyas Misra <[email protected]>
…IA#5262) Signed-off-by: Yue Weng <[email protected]> Signed-off-by: Ransiki Zhang <[email protected]>
…IA#5262) Signed-off-by: Yue Weng <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>
4 participants
Description
Problem: When using relaxed acceptance, there is an H2D async copy, which will cause
cudaStreamSynchronize(). And further block the performance of the overlap scheduler.Solution:
Change
xxx[id] = 0toxxx._copy(0, non_blocking=True).Timeline anyasis:
cudaStreamSynchronize()->cudaMemcpyAsync()AR & perf anyasis: AR has not changed, TPS has increased slightly.
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit
Summary by CodeRabbit
Performance Improvements
Bug Fixes
End-users may notice improved performance and reliability in speculative decoding features.