Skip to content

fix: Fix skip by mpi size fixture #5355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025
Merged

fix: Fix skip by mpi size fixture #5355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tests/integration/defs/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1817,12 +1817,18 @@ def skip_by_mpi_world_size(request):
"fixture for skip less device count"
if request.node.get_closest_marker('skip_less_mpi_world_size'):
mpi_world_size = get_mpi_world_size()
device_count = get_device_count()
if mpi_world_size == 1:
# For mpi_world_size == 1 case, we only need to check device count since we can spawn mpi workers in the test itself
total_count = device_count
else:
# Otherwise, we follow the mpi world size setting
total_count = mpi_world_size
expected_count = request.node.get_closest_marker(
'skip_less_mpi_world_size').args[0]
if expected_count > int(mpi_world_size):
if expected_count > int(total_count):
pytest.skip(
f'MPI world size {mpi_world_size} is less than {expected_count}'
)
f'Total world size {total_count} is less than {expected_count}')


@pytest.fixture(autouse=True)
Expand Down