Skip to content

Conversation

kaiyux
Copy link
Member

@kaiyux kaiyux commented Jun 24, 2025

feat: Make benchmark_serving part of the library

Description

The scripts can be executed after tensorrt_llm installation, for example:

python -m tensorrt_llm.serve.scripts.benchmark_serving --help

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@kaiyux kaiyux requested review from Superjomn and LinPoly June 24, 2025 08:51
@kaiyux
Copy link
Member Author

kaiyux commented Jun 24, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9670 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9670 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7109 completed with status: 'FAILURE'

@kaiyux
Copy link
Member Author

kaiyux commented Jun 24, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9705 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9705 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7140 completed with status: 'FAILURE'

@kaiyux
Copy link
Member Author

kaiyux commented Jun 25, 2025

/bot run --disable-fail-fast

@kaiyux kaiyux requested a review from nv-guomingz June 25, 2025 02:01
@tensorrt-cicd
Copy link
Collaborator

PR_Github #9785 [ run ] triggered by Bot

@Superjomn
Copy link
Collaborator

Any need for usage doc somewhere?

Copy link
Collaborator

@nv-guomingz nv-guomingz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyux
Copy link
Member Author

kaiyux commented Jun 25, 2025

Any need for usage doc somewhere?

@Superjomn Since we don't have any document for benchmark_serving.py script for now, I was thinking we can add later together with the document refactor, on this page https://nvidia.github.io/TensorRT-LLM/commands/trtllm-serve.html#benchmark, does that work? (cc @nv-guomingz )

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9785 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7214 completed with status: 'FAILURE'

Copy link
Collaborator

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LinPoly LinPoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyux
Copy link
Member Author

kaiyux commented Jun 25, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9850 [ run ] triggered by Bot

@kaiyux kaiyux force-pushed the user/kaiyu/bench_serve_lib branch from 8063ce4 to dc93b6b Compare June 25, 2025 10:25
@kaiyux
Copy link
Member Author

kaiyux commented Jun 25, 2025

/bot run --disable-fail-fast

@kaiyux kaiyux enabled auto-merge (squash) June 25, 2025 10:26
@tensorrt-cicd
Copy link
Collaborator

PR_Github #9867 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9850 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9867 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7280 completed with status: 'SUCCESS'

@kaiyux kaiyux merged commit c5ae327 into NVIDIA:main Jun 25, 2025
3 checks passed
@kaiyux kaiyux deleted the user/kaiyu/bench_serve_lib branch June 25, 2025 16:26
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 9, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants