Skip to content

Conversation

FrankD412
Copy link
Collaborator

Description

This MR updates the code owners for trtllm-bench to allow for auto-tagging of reviewers for changes to the benchmarks.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@FrankD412
Copy link
Collaborator Author

@juney-nvidia @kaiyux -- it looks like the group may not have write access to the repository. The team is visible (it shows up in tagging) but GitHub still flags the ownership file as having issues.

Copy link
Collaborator

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn
Copy link
Collaborator

@FrankD412 Saw the following GitHub errors, seems we need to create the GitHub team accordingly:

Unknown owner on line 18: make sure the team @NVIDIA/trtllm-bench-reviewers exists, is publicly visible, and has write access to the repository
/tensorrt_llm/bench @NVIDIA/trtllm-bench-reviewers
Unknown owner on line 19: make sure the team @NVIDIA/trtllm-bench-reviewers exists, is publicly visible, and has write access to the repository
…ensorrt_llm/commands/bench.py @NVIDIA/trtllm-bench-reviewers
Unknown owner on line 20: make sure the team @NVIDIA/trtllm-bench-reviewers exists, is publicly visible, and has write access to the repository
…formance/perf-benchmarking.md @NVIDIA/trtllm-bench-reviewers

@FrankD412
Copy link
Collaborator Author

@FrankD412 Saw the following GitHub errors, seems we need to create the GitHub team accordingly:

Unknown owner on line 18: make sure the team @NVIDIA/trtllm-bench-reviewers exists, is publicly visible, and has write access to the repository
/tensorrt_llm/bench @NVIDIA/trtllm-bench-reviewers
Unknown owner on line 19: make sure the team @NVIDIA/trtllm-bench-reviewers exists, is publicly visible, and has write access to the repository
…ensorrt_llm/commands/bench.py @NVIDIA/trtllm-bench-reviewers
Unknown owner on line 20: make sure the team @NVIDIA/trtllm-bench-reviewers exists, is publicly visible, and has write access to the repository
…formance/perf-benchmarking.md @NVIDIA/trtllm-bench-reviewers

Yeah -- the team is visible so far as I can tell, I think it needs access to write to the repository.

@kaiyux
Copy link
Member

kaiyux commented Jun 26, 2025

@FrankD412 Saw the following GitHub errors, seems we need to create the GitHub team accordingly:

Unknown owner on line 18: make sure the team @NVIDIA/trtllm-bench-reviewers exists, is publicly visible, and has write access to the repository
/tensorrt_llm/bench @NVIDIA/trtllm-bench-reviewers
Unknown owner on line 19: make sure the team @NVIDIA/trtllm-bench-reviewers exists, is publicly visible, and has write access to the repository
…ensorrt_llm/commands/bench.py @NVIDIA/trtllm-bench-reviewers
Unknown owner on line 20: make sure the team @NVIDIA/trtllm-bench-reviewers exists, is publicly visible, and has write access to the repository
…formance/perf-benchmarking.md @NVIDIA/trtllm-bench-reviewers

Yeah -- the team is visible so far as I can tell, I think it needs access to write to the repository.

I added the write permission and it should be working now.

Signed-off-by: Frank Di Natale <[email protected]>
Signed-off-by: Frank Di Natale <[email protected]>
@kaiyux kaiyux force-pushed the fdinatale/trtllm-bench/codeowners branch from 0b74bd3 to 0da251a Compare June 26, 2025 10:36
@kaiyux
Copy link
Member

kaiyux commented Jun 26, 2025

/bot skip --comment "codeowner changes"

@kaiyux kaiyux enabled auto-merge (squash) June 26, 2025 10:37
@tensorrt-cicd
Copy link
Collaborator

PR_Github #10028 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10028 [ skip ] completed with state SUCCESS
Skipping testing for commit 0da251a

@kaiyux kaiyux merged commit baf7eaa into NVIDIA:main Jun 26, 2025
3 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 9, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants