Skip to content

chore: refine the default value by using pydantic default instead of … #5695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

chore: refine the default value by using pydantic default instead of … #5695

merged 1 commit into from
Jul 3, 2025

Conversation

nv-guomingz
Copy link
Collaborator

Inspired by this comment.

@nv-guomingz nv-guomingz requested review from Superjomn and syuoni July 3, 2025 03:43
@nv-guomingz
Copy link
Collaborator Author

/bot run --disable-fail-fast

Superjomn
Superjomn approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10748 [ run ] triggered by Bot

@nv-guomingz nv-guomingz force-pushed the user/guomingz/refine_default_value_llm_args branch from 22befbc to deb8ad4 Compare July 3, 2025 06:08
@tensorrt-cicd
Copy link
Collaborator

PR_Github #10748 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7939 completed with status: 'FAILURE'

@nv-guomingz
Copy link
Collaborator Author

/bot run

@nv-guomingz nv-guomingz enabled auto-merge (squash) July 3, 2025 06:46
@tensorrt-cicd
Copy link
Collaborator

PR_Github #10769 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10769 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7955 completed with status: 'FAILURE'

@nv-guomingz
Copy link
Collaborator Author

/bot run --stage-list "RTX5080-TensorRT-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10787 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10787 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7965 (Partly Tested) completed with status: 'SUCCESS'

@nv-guomingz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10807 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10807 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7982 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@nv-guomingz nv-guomingz merged commit 8dad22c into NVIDIA:main Jul 3, 2025
3 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 9, 2025
@nv-guomingz @dominicshanshan
chore: refine the default value by using pydantic default instead of … (
11e777b 
NVIDIA#5695)

Signed-off-by: nv-guomingz <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
@nv-guomingz @dominicshanshan
chore: refine the default value by using pydantic default instead of … (
0a07704 
NVIDIA#5695)

Signed-off-by: nv-guomingz <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
@nv-guomingz @dominicshanshan
chore: refine the default value by using pydantic default instead of … (
a4f34b1 
NVIDIA#5695)

Signed-off-by: nv-guomingz <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
@nv-guomingz @dominicshanshan
chore: refine the default value by using pydantic default instead of … (
d883e0e 
NVIDIA#5695)

Signed-off-by: nv-guomingz <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
@nv-guomingz @dominicshanshan
chore: refine the default value by using pydantic default instead of … (
ac03ecd 
NVIDIA#5695)

Signed-off-by: nv-guomingz <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
@nv-guomingz @dominicshanshan
chore: refine the default value by using pydantic default instead of … (
7fb7592 
NVIDIA#5695)

Signed-off-by: nv-guomingz <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
@nv-guomingz @dominicshanshan
chore: refine the default value by using pydantic default instead of … (
e0ad0b7 
NVIDIA#5695)

Signed-off-by: nv-guomingz <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
@nv-guomingz @dominicshanshan
chore: refine the default value by using pydantic default instead of … (
6c78866 
NVIDIA#5695)

Signed-off-by: nv-guomingz <[email protected]>
zhou-yuxin pushed a commit to zhou-yuxin/TensorRT-LLM that referenced this pull request Jul 15, 2025
@nv-guomingz @zhou-yuxin
chore: refine the default value by using pydantic default instead of … (
0f18869 
NVIDIA#5695)

Signed-off-by: nv-guomingz <[email protected]>
Signed-off-by: Yuxin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Superjomn Superjomn Superjomn approved these changes

@syuoni syuoni syuoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nv-guomingz @tensorrt-cicd @Superjomn @syuoni