-
Notifications
You must be signed in to change notification settings - Fork 1.8k
delete duplicate eagle3 and ngram tests #5711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
omera-nv
merged 1 commit into
NVIDIA:main
from
netanel-haber:user/nhaber/fix/delete-duplicate-eagle3-and-ngram-tests
Jul 3, 2025
Merged
delete duplicate eagle3 and ngram tests #5711
omera-nv
merged 1 commit into
NVIDIA:main
from
netanel-haber:user/nhaber/fix/delete-duplicate-eagle3-and-ngram-tests
Jul 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of: - `unittest/_torch/speculative/test_eagle3.py` - `unittest/_torch/speculative/test_ngram.py` Are already covered by: `unittest/_torch -k "not (modeling or multi_gpu or auto_deploy)"` Signed-off-by: Netanel Haber <[email protected]>
omera-nv
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/bot skip --comment "removing tests from test lists, no need to run CI" |
PR_Github #10825 [ skip ] triggered by Bot |
PR_Github #10825 [ skip ] completed with state |
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 9, 2025
Signed-off-by: Netanel Haber <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Netanel Haber <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Netanel Haber <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Netanel Haber <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Netanel Haber <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 11, 2025
Signed-off-by: Netanel Haber <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 11, 2025
Signed-off-by: Netanel Haber <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 11, 2025
Signed-off-by: Netanel Haber <[email protected]>
zhou-yuxin
pushed a commit
to zhou-yuxin/TensorRT-LLM
that referenced
this pull request
Jul 15, 2025
Signed-off-by: Netanel Haber <[email protected]> Signed-off-by: Yuxin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of:
unittest/_torch/speculative/test_eagle3.py
unittest/_torch/speculative/test_ngram.py
Are already covered by:
unittest/_torch -k "not (modeling or multi_gpu or auto_deploy)"
To confirm, run:
pytest --collect-only --quiet tests/unittest/_torch -k "not (modeling or multi_gpu or auto_deploy)" | grep speculative