Skip to content

Conversation

lucaslie
Copy link
Member

@lucaslie lucaslie commented Jul 3, 2025

see nv-auto-deploy/TensorRT-LLM@main...nv-auto-deploy:TensorRT-LLM:feat/ad-2025-06-29 for overview of PRs and commits with detailed description

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

nzmora-nvidia and others added 4 commits July 3, 2025 15:44
* fix README to use kebab-case cli options

Signed-off-by: Lucas Liebenwein <[email protected]>

* more readme updates

Signed-off-by: Lucas Liebenwein <[email protected]>

---------

Signed-off-by: Lucas Liebenwein <[email protected]>
* fix when top_k is set up None for demollm, add unit test

Signed-off-by: Frida Hou <[email protected]>

* minor updates around demollm sampler

Signed-off-by: Frida Hou <[email protected]>

* minor updates for the feedback

Signed-off-by: Frida Hou <[email protected]>

---------

Signed-off-by: Frida Hou <[email protected]>
@lucaslie lucaslie requested review from a team as code owners July 3, 2025 22:55
@lucaslie lucaslie requested a review from suyoggupta July 3, 2025 22:55
@lucaslie lucaslie moved this from Backlog to In review in AutoDeploy Board Jul 3, 2025
@lucaslie
Copy link
Member Author

lucaslie commented Jul 3, 2025

/bot run

@lucaslie lucaslie enabled auto-merge (squash) July 3, 2025 23:00
@lucaslie lucaslie disabled auto-merge July 3, 2025 23:00
@lucaslie lucaslie changed the title [AutoDeploy] merge feat/ad-2025-06-24 [AutoDeploy] merge feat/ad-2025-06-29 Jul 3, 2025
@lucaslie lucaslie enabled auto-merge (squash) July 3, 2025 23:00
@lucaslie lucaslie requested a review from FrankD412 July 3, 2025 23:00
@tensorrt-cicd
Copy link
Collaborator

PR_Github #10880 [ run ] triggered by Bot

@lucaslie lucaslie requested a review from Copilot July 3, 2025 23:05
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges the feat/ad-2025-06-29 branch into main, adding comprehensive AutoDeploy support, new model patches, benchmark integration, and updated examples.

  • Adds single-GPU benchmark tests and engine sampling tests
  • Introduces export-time patches for torch.tensor and Transformers SDPA masking
  • Implements MoE export patches (Mixtral + Qwen3) and updates throughput to handle _autodeploy backend
  • Renames CLI options in examples to hyphenated form and enhances VSCode test settings

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

File Description
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py Adds end-to-end benchmark test without verifications
tensorrt_llm/_torch/auto_deploy/models/qwen3.py Defines _forward_moe but does not patch forward method
tensorrt_llm/bench/dataclasses/configuration.py Simplifies get_autodeploy_perf_config to return a bare dict
tests/unittest/_torch/auto_deploy/unit/singlegpu/shim/test_engine.py Adds sampling tests for DemoEngine
Comments suppressed due to low confidence (1)

tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:62

  • This test invokes the CLI but doesn't assert the exit code or output. Add result = runner.invoke(...) and assert result.exit_code == 0 (and optionally check key output) to ensure the command succeeded.
    runner.invoke(main, args, catch_exceptions=False)

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10880 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8042 completed with status: 'SUCCESS'

@lucaslie lucaslie merged commit 24ac9b5 into NVIDIA:main Jul 4, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in AutoDeploy Board Jul 4, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 9, 2025
Signed-off-by: Lucas Liebenwein <[email protected]>
Signed-off-by: Frida Hou <[email protected]>
Co-authored-by: Neta Zmora <[email protected]>
Co-authored-by: Fridah-nv <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
Signed-off-by: Lucas Liebenwein <[email protected]>
Signed-off-by: Frida Hou <[email protected]>
Co-authored-by: Neta Zmora <[email protected]>
Co-authored-by: Fridah-nv <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
Signed-off-by: Lucas Liebenwein <[email protected]>
Signed-off-by: Frida Hou <[email protected]>
Co-authored-by: Neta Zmora <[email protected]>
Co-authored-by: Fridah-nv <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
Signed-off-by: Lucas Liebenwein <[email protected]>
Signed-off-by: Frida Hou <[email protected]>
Co-authored-by: Neta Zmora <[email protected]>
Co-authored-by: Fridah-nv <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
Signed-off-by: Lucas Liebenwein <[email protected]>
Signed-off-by: Frida Hou <[email protected]>
Co-authored-by: Neta Zmora <[email protected]>
Co-authored-by: Fridah-nv <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
Signed-off-by: Lucas Liebenwein <[email protected]>
Signed-off-by: Frida Hou <[email protected]>
Co-authored-by: Neta Zmora <[email protected]>
Co-authored-by: Fridah-nv <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
Signed-off-by: Lucas Liebenwein <[email protected]>
Signed-off-by: Frida Hou <[email protected]>
Co-authored-by: Neta Zmora <[email protected]>
Co-authored-by: Fridah-nv <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
Signed-off-by: Lucas Liebenwein <[email protected]>
Signed-off-by: Frida Hou <[email protected]>
Co-authored-by: Neta Zmora <[email protected]>
Co-authored-by: Fridah-nv <[email protected]>
zhou-yuxin pushed a commit to zhou-yuxin/TensorRT-LLM that referenced this pull request Jul 15, 2025
Signed-off-by: Lucas Liebenwein <[email protected]>
Signed-off-by: Frida Hou <[email protected]>
Co-authored-by: Neta Zmora <[email protected]>
Co-authored-by: Fridah-nv <[email protected]>
Signed-off-by: Yuxin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants