-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[AutoDeploy] merge feat/ad-2025-06-29 #5737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* fix README to use kebab-case cli options Signed-off-by: Lucas Liebenwein <[email protected]> * more readme updates Signed-off-by: Lucas Liebenwein <[email protected]> --------- Signed-off-by: Lucas Liebenwein <[email protected]>
* fix when top_k is set up None for demollm, add unit test Signed-off-by: Frida Hou <[email protected]> * minor updates around demollm sampler Signed-off-by: Frida Hou <[email protected]> * minor updates for the feedback Signed-off-by: Frida Hou <[email protected]> --------- Signed-off-by: Frida Hou <[email protected]>
Signed-off-by: Lucas Liebenwein <[email protected]>
/bot run |
PR_Github #10880 [ run ] triggered by Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR merges the feat/ad-2025-06-29
branch into main
, adding comprehensive AutoDeploy support, new model patches, benchmark integration, and updated examples.
- Adds single-GPU benchmark tests and engine sampling tests
- Introduces export-time patches for
torch.tensor
and Transformers SDPA masking - Implements MoE export patches (Mixtral + Qwen3) and updates throughput to handle
_autodeploy
backend - Renames CLI options in examples to hyphenated form and enhances VSCode test settings
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py | Adds end-to-end benchmark test without verifications |
tensorrt_llm/_torch/auto_deploy/models/qwen3.py | Defines _forward_moe but does not patch forward method |
tensorrt_llm/bench/dataclasses/configuration.py | Simplifies get_autodeploy_perf_config to return a bare dict |
tests/unittest/_torch/auto_deploy/unit/singlegpu/shim/test_engine.py | Adds sampling tests for DemoEngine |
Comments suppressed due to low confidence (1)
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:62
- This test invokes the CLI but doesn't assert the exit code or output. Add
result = runner.invoke(...)
andassert result.exit_code == 0
(and optionally check key output) to ensure the command succeeded.
runner.invoke(main, args, catch_exceptions=False)
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py
Show resolved
Hide resolved
PR_Github #10880 [ run ] completed with state |
Signed-off-by: Lucas Liebenwein <[email protected]> Signed-off-by: Frida Hou <[email protected]> Co-authored-by: Neta Zmora <[email protected]> Co-authored-by: Fridah-nv <[email protected]>
Signed-off-by: Lucas Liebenwein <[email protected]> Signed-off-by: Frida Hou <[email protected]> Co-authored-by: Neta Zmora <[email protected]> Co-authored-by: Fridah-nv <[email protected]>
Signed-off-by: Lucas Liebenwein <[email protected]> Signed-off-by: Frida Hou <[email protected]> Co-authored-by: Neta Zmora <[email protected]> Co-authored-by: Fridah-nv <[email protected]>
Signed-off-by: Lucas Liebenwein <[email protected]> Signed-off-by: Frida Hou <[email protected]> Co-authored-by: Neta Zmora <[email protected]> Co-authored-by: Fridah-nv <[email protected]>
Signed-off-by: Lucas Liebenwein <[email protected]> Signed-off-by: Frida Hou <[email protected]> Co-authored-by: Neta Zmora <[email protected]> Co-authored-by: Fridah-nv <[email protected]>
Signed-off-by: Lucas Liebenwein <[email protected]> Signed-off-by: Frida Hou <[email protected]> Co-authored-by: Neta Zmora <[email protected]> Co-authored-by: Fridah-nv <[email protected]>
Signed-off-by: Lucas Liebenwein <[email protected]> Signed-off-by: Frida Hou <[email protected]> Co-authored-by: Neta Zmora <[email protected]> Co-authored-by: Fridah-nv <[email protected]>
Signed-off-by: Lucas Liebenwein <[email protected]> Signed-off-by: Frida Hou <[email protected]> Co-authored-by: Neta Zmora <[email protected]> Co-authored-by: Fridah-nv <[email protected]>
Signed-off-by: Lucas Liebenwein <[email protected]> Signed-off-by: Frida Hou <[email protected]> Co-authored-by: Neta Zmora <[email protected]> Co-authored-by: Fridah-nv <[email protected]> Signed-off-by: Yuxin <[email protected]>
see nv-auto-deploy/TensorRT-LLM@main...nv-auto-deploy:TensorRT-LLM:feat/ad-2025-06-29 for overview of PRs and commits with detailed description
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...
Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]
to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]
Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast
(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test
(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"
(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"
(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test
(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test
(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test
(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge
(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"
(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md
.kill
kill
Kill all running builds associated with pull request.
skip
skip --comment COMMENT
Skip testing for latest commit on pull request.
--comment "Reason for skipping build/test"
is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.