[nvbugs/5326453] Avoid nesting NCCL grouping in allgather OP #5789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3a58db8.
Signed-off-by: junq <[email protected]>
Signed-off-by: junq <[email protected]>
QiJune
requested review from
achartier,
litaotju,
dongxuy04,
lfr-0531,
kaiyux and
jinyangyuan-nvidia
QiJune
commented
Jul 7, 2025
|
/bot run |
lfr-0531
approved these changes
Jul 7, 2025
|
PR_Github #11125 [ run ] triggered by Bot |
achartier
reviewed
Jul 7, 2025
|
PR_Github #11125 [ run ] completed with state |
Signed-off-by: junq <[email protected]>
achartier
approved these changes
Jul 8, 2025
kaiyux
approved these changes
Jul 8, 2025
|
/bot skip --comment "previous pipeline passed, skip the last code comment changes" |
|
/bot run |
|
/bot skip --comment "previous pipeline passed, skip the last code comment changes" |
|
/bot skip --comment "previous pipeline passed, skip the last code comment changes" |
|
PR_Github #11226 [ skip ] triggered by Bot |
|
PR_Github #11226 [ skip ] completed with state |
dc3671
pushed a commit
to dc3671/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
…5789) Signed-off-by: junq <[email protected]>
dc3671
pushed a commit
to dc3671/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
…5789) Signed-off-by: junq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the WAR #5583, and fix the real rootcause in allgather OP