-
Notifications
You must be signed in to change notification settings - Fork 1.8k
tests: add timeout_manager to tensorrt flow test cases #5942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
be2294f
to
0efe7ba
Compare
/bot run |
PR_Github #11750 [ run ] triggered by Bot |
PR_Github #11750 [ run ] completed with state |
0efe7ba
to
10b9dcc
Compare
/bot run --stage-list "B200_PCIe-PyTorch-1" |
PR_Github #11766 [ run ] triggered by Bot |
PR_Github #11766 [ run ] completed with state |
Signed-off-by: Ivy Zhang <[email protected]>
Signed-off-by: Ivy Zhang <[email protected]>
Signed-off-by: Ivy Zhang <[email protected]>
Signed-off-by: Ivy Zhang <[email protected]>
Signed-off-by: Ivy Zhang <[email protected]>
Signed-off-by: Ivy Zhang <[email protected]>
10b9dcc
to
f13c0ab
Compare
/bot run |
PR_Github #12053 [ run ] triggered by Bot |
PR_Github #12053 [ run ] completed with state |
@EmmaQiaoCh Could you please help review this PR? |
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Caution Review failedThe pull request is closed. WalkthroughTimeout management was integrated across multiple integration test modules. A new Changes
Sequence Diagram(s)sequenceDiagram
participant Pytest
participant Fixture
participant TestFunction
participant TimeoutManager
participant Subprocess
Pytest->>Fixture: Request test with timeout
Fixture->>TimeoutManager: Instantiate with timeout value
Fixture->>TestFunction: Inject timeout_manager
loop For each major test phase
TestFunction->>TimeoutManager: Enter timed_operation("phase")
TimeoutManager->>Subprocess: Call with remaining timeout
Subprocess-->>TimeoutManager: Return/raise on completion or timeout
TimeoutManager-->>TestFunction: Exit context, update remaining timeout
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (12)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Ivy Zhang <[email protected]> Signed-off-by: Shreyas Misra <[email protected]>
Signed-off-by: Ivy Zhang <[email protected]> Signed-off-by: Ransiki Zhang <[email protected]>
…A#5942)" (NVIDIA#6309) Signed-off-by: Ransiki Zhang <[email protected]>
…A#5942)" (NVIDIA#6309) Signed-off-by: Lanyu Liao <[email protected]>
Description
Due to intensive test workloads, some machines experience hang issues during test execution, affecting overall test stability and completion.
This PR adds timeout management system to handle TensorRT flow test cases with proper resource cleanup.
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...
Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]
to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]
Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast
(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test
(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"
(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"
(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test
(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test
(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test
(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge
(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"
(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md
.kill
kill
Kill all running builds associated with pull request.
skip
skip --comment COMMENT
Skip testing for latest commit on pull request.
--comment "Reason for skipping build/test"
is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit
New Features
Bug Fixes
Chores