-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[nvbug/5374773] chore: Add a runtime flag to enable fail fast when attn window is too large to fit at least one sequence in KV cache #5974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/bot run |
|
PR_Github #11674 [ run ] triggered by Bot |
|
PR_Github #11674 [ run ] completed with state |
|
/bot run |
|
PR_Github #11698 [ run ] triggered by Bot |
|
PR_Github #11698 [ run ] completed with state |
jaedeok-nvidia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good. Especially, it will provide an explicit option for very-limited memory scenario.
netanel-haber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments suggesting changes to wording of doc comments - at the author's discretion if to resolve without notice or to accept some form of the changes. But otherwise - LGTM.
|
@nv-guomingz could you review it while Chunwei is out? Thanks |
|
/bot run |
|
PR_Github #12877 [ run ] triggered by Bot |
|
PR_Github #12877 [ run ] completed with state |
nv-guomingz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for llm api part
Signed-off-by: moraxu <[email protected]>
Signed-off-by: moraxu <[email protected]>
Signed-off-by: moraxu <[email protected]>
Signed-off-by: moraxu <[email protected]>
Signed-off-by: moraxu <[email protected]>
Signed-off-by: moraxu <[email protected]>
Signed-off-by: moraxu <[email protected]>
Signed-off-by: moraxu <[email protected]>
Signed-off-by: moraxu <[email protected]>
c0914ab to
2e454a2
Compare
|
/bot reuse-pipeline |
|
/bot reuse-pipeline |
|
PR_Github #13040 [ reuse-pipeline ] triggered by Bot |
|
PR_Github #13040 [ reuse-pipeline ] completed with state |
…tn window is too large to fit at least one sequence in KV cache (NVIDIA#5974) Signed-off-by: moraxu <[email protected]> Signed-off-by: Shreyas Misra <[email protected]>
…tn window is too large to fit at least one sequence in KV cache (NVIDIA#5974) Signed-off-by: moraxu <[email protected]> Signed-off-by: Ransiki Zhang <[email protected]>
|
Can you add the changes that you did to |
Added in #6491 |
…tn window is too large to fit at least one sequence in KV cache (NVIDIA#5974) Signed-off-by: moraxu <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>
Description
As per NIM request, add a runtime flag to enable fail fast when attn window is too large to fit at least one sequence in KV cache.
Test Coverage
For now, tested with:
and:
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit