Skip to content

BlockManager copy constructor fix #5982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

BlockManager copy constructor fix #5982

merged 1 commit into from
Jul 16, 2025

Conversation

@tshmilnvidia
Copy link
Collaborator

@tshmilnvidia tshmilnvidia commented Jul 13, 2025

Remove unwanted copying of BlockManager in UT.
Also Delete BlockManager copy constructor & operator= so this mistake is never repeated.

@svc-trtllm-gh-bot svc-trtllm-gh-bot added the Community want to contribute PRs initiated from Community label Jul 13, 2025
@tshmilnvidia tshmilnvidia mentioned this pull request Jul 13, 2025
Merged
@tshmilnvidia tshmilnvidia force-pushed the copy_constuctor_bug branch from fcb8b82 to 4a6dd5a Compare July 13, 2025 14:59
@Tabrizian Tabrizian requested a review from thorjohnsen July 14, 2025 17:11
@Tabrizian Tabrizian force-pushed the copy_constuctor_bug branch from 4a6dd5a to 387e5b3 Compare July 14, 2025 17:11
@Tabrizian
Copy link
Member

Tabrizian commented Jul 14, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Jul 14, 2025

PR_Github #11834 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Jul 14, 2025

PR_Github #11834 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8770 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@Tabrizian
Copy link
Member

Tabrizian commented Jul 14, 2025

@tshmilnvidia It looks like there is an issue with commit sign off:

Tomer Shmilovich, Committer: Iman Tabrizian; Expected "Tomer Shmilovich [[email protected]](mailto:[email protected])", but got "Tomer Shmilovich [[email protected]](mailto:[email protected])".

Could you please fix it?

@tshmilnvidia tshmilnvidia force-pushed the copy_constuctor_bug branch from 387e5b3 to 7df5886 Compare July 15, 2025 07:38
@Tabrizian Tabrizian force-pushed the copy_constuctor_bug branch from 7df5886 to 2b5e3fd Compare July 15, 2025 16:12
@Tabrizian Tabrizian enabled auto-merge (squash) July 15, 2025 16:12
@Tabrizian
Copy link
Member

Tabrizian commented Jul 15, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Jul 15, 2025

PR_Github #11958 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Jul 15, 2025

PR_Github #11958 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8875 completed with status: 'FAILURE'

@tshmilnvidia @Tabrizian
BlockManager copy constructor fix
a0a1596 
Remove unwanted copying of BlockManager in UT.
Also Delete BlockManager copy constructor & operator= so this mistake
is never repeated.

Signed-off-by: Tomer Shmilovich <[email protected]>
@Tabrizian Tabrizian force-pushed the copy_constuctor_bug branch from 2b5e3fd to a0a1596 Compare July 16, 2025 06:55
@Tabrizian
Copy link
Member

Tabrizian commented Jul 16, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Jul 16, 2025

PR_Github #12040 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Jul 16, 2025

PR_Github #12040 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8941 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@Tabrizian Tabrizian merged commit 0552a02 into NVIDIA:main Jul 16, 2025
2 checks passed
evezhier pushed a commit to evezhier/TensorRT-LLM that referenced this pull request Jul 16, 2025
@tshmilnvidia @evezhier
BlockManager copy constructor fix (NVIDIA#5982)
4f15810 
Signed-off-by: Tomer Shmilovich <[email protected]>
yizhang-nv pushed a commit to yizhang-nv/TensorRT-LLM that referenced this pull request Jul 17, 2025
@tshmilnvidia @yizhang-nv
BlockManager copy constructor fix (NVIDIA#5982)
7867319 
Signed-off-by: Tomer Shmilovich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tabrizian Tabrizian Tabrizian approved these changes

@Shixiaowei02 Shixiaowei02 Shixiaowei02 approved these changes

@thorjohnsen thorjohnsen Awaiting requested review from thorjohnsen

Assignees

No one assigned

Labels

Community want to contribute PRs initiated from Community

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tshmilnvidia @Tabrizian @tensorrt-cicd @Shixiaowei02 @svc-trtllm-gh-bot