[None][fix] Remove lock related typo in py_executor

[lancelly]

This PR aims to:

1. Eliminates lock operations inside try blocks which could lead to unnecessary unlock operation.
2. Fixes potential concurrency issue in can_enqueue_request. self.active could be modified after releasing the lock.

Summary by CodeRabbit

• Refactor
  • Improved internal lock handling for better reliability and code clarity. No changes to user-facing functionality.

[coderabbitai]

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

193 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Lock handling in multiple methods across two modules was refactored to use Python's context manager (with statement) instead of explicit acquire() and release() calls. This affects synchronization logic within request queue and executor statistics methods, but does not alter any method signatures or overall control flow.

Changes

File(s)	Change Summary
tensorrt_llm/_torch/pyexecutor/executor_request_queue.py	Replaced explicit enqueue_lock.acquire()/release() calls with with self.enqueue_lock: in multiple enqueue-related methods.
tensorrt_llm/_torch/pyexecutor/py_executor.py	Replaced explicit worker_lock and stats_lock acquire/release calls with with context managers in start_worker, get_latest_iteration_stats, and _append_iter_stats.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• feat: Refactor the fetching request logic #5786: Introduces the ExecutorRequestQueue class and its enqueue methods, which are refactored in this PR.

Suggested reviewers

• HuiGao-NV
• QiJune
• pcastonguay

Poem

With locks now wrapped in Python's gentle care,
No more manual release—no need to beware!
Context managers hop in, so clean and so neat,
Making thread safety a rabbit-sized treat.
Code now is safer, and bugs take their flight—
A hop, skip, and jump, and all locks are right! 🐇

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lancelly]

/bot run

[lancelly]

/bot run

[tensorrt-cicd]

PR_Github #13955 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #13955 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #10511 completed with status: 'FAILURE'

[lancelly]

/bot run

[tensorrt-cicd]

PR_Github #13981 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #13981 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #10533 completed with status: 'FAILURE'

[lancelly]

/bot run

[tensorrt-cicd]

PR_Github #14093 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #14093 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10634 completed with status: 'FAILURE'

[lancelly]

/bot run

[tensorrt-cicd]

PR_Github #14128 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #14128 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10660 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.