[TRTLLM-5312][infra] Add triton trigger rules #6440

yiqingy0 · 2025-07-29T08:30:25Z

Summary by CodeRabbit

New Features
- Added support for triggering Triton-related tests and tags when files under specific Triton directories are changed.
- Included the "triton" backend in test stage filtering, allowing Triton tests to be run alongside other backends.
- Added the Triton 3.3.1 dependency to the project.
Bug Fixes
- Adjusted test filtering so that Triton tests are now executed even when only PyTorch files are changed.

Description

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

coderabbitai · 2025-07-29T08:30:32Z

📝 Walkthrough

Walkthrough

This change updates Jenkins pipeline scripts to add Triton-related paths to the auto-trigger tag mapping and includes the "triton" backend in the test backend-to-stage mapping. It also modifies the logic to allow Triton tests to run when only PyTorch files have changed. Additionally, it adds the triton==3.3.1 dependency to requirements.txt.

Changes

Cohort / File(s)	Change Summary
Auto-trigger tag mapping `jenkins/L0_MergeRequest.groovy`	Added Triton-related paths to the `specialFileToTagMap` to trigger the `-Triton-` tag for changes under those paths.
Test backend filtering and group logic `jenkins/L0_Test.groovy`	Added "triton" to backend-to-stage mapping; updated logic to run Triton tests when only PyTorch files change.
Dependency update `requirements.txt`	Added new dependency `triton==3.3.1`.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Jenkins
    participant TestLauncher

    Developer->>Jenkins: Submit PR with file changes
    Jenkins->>Jenkins: getAutoTriggerTagList() checks changed paths
    Jenkins->>Jenkins: Map Triton-related paths to "-Triton-" tag
    Jenkins->>TestLauncher: launchTestJobs() determines backends to test
    TestLauncher->>TestLauncher: Allow Triton tests to run if only PyTorch files changed

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

[TRTLLM-5312] - Add bot run rules for triton tests #4988: Extends file-to-tag and group mapping for Triton paths and adjusts test backend filtering, directly related to the group-based file change detection and test filtering logic updated in this PR.

Suggested reviewers

niukuo
ZhanruiSunCh

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e902c95 and b01f1f7.

📒 Files selected for processing (1)

requirements.txt (1 hunks)

✅ Files skipped from review due to trivial changes (1)

requirements.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

yiqingy0 · 2025-07-29T08:34:36Z

/bot run

tensorrt-cicd · 2025-07-29T08:39:39Z

PR_Github #13334 [ run ] triggered by Bot

yiqingy0 · 2025-07-29T10:27:46Z

/bot run

tensorrt-cicd · 2025-07-29T10:33:15Z

PR_Github #13353 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-29T10:33:17Z

PR_Github #13334 [ run ] completed with state ABORTED

tensorrt-cicd · 2025-07-30T02:19:20Z

PR_Github #13353 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9983 completed with status: 'FAILURE'

yiqingy0 · 2025-07-30T03:12:47Z

/LLM/main/L0_MergeRequest_PR pipeline #9983 This is the test for only modify triton files.

yiqingy0 · 2025-07-30T03:16:52Z

/bot run

tensorrt-cicd · 2025-07-30T03:22:58Z

PR_Github #13465 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-30T07:01:22Z

PR_Github #13465 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10079 completed with status: 'FAILURE'

yiqingy0 · 2025-07-30T07:43:20Z

/bot run

yiqingy0 · 2025-07-30T07:44:35Z

/LLM/main/L0_MergeRequest_PR pipeline #10079 This is the test for modify triton and other tests

yiqingy0 · 2025-07-30T07:47:43Z

/bot run

tensorrt-cicd · 2025-07-30T07:48:56Z

PR_Github #13510 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-30T07:53:34Z

PR_Github #13511 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-30T07:53:36Z

PR_Github #13510 [ run ] completed with state ABORTED

tensorrt-cicd · 2025-07-30T20:33:09Z

PR_Github #13511 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10122 completed with status: 'SUCCESS'

yiqingy0 · 2025-07-31T02:33:01Z

/LLM/main/L0_MergeRequest_PR pipeline #10122 This is the test for only modify pytorch files

yiqingy0 · 2025-07-31T02:36:32Z

/bot run

tensorrt-cicd · 2025-07-31T02:42:15Z

PR_Github #13595 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-31T04:27:15Z

PR_Github #13595 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10194 completed with status: 'FAILURE'

yiqingy0 · 2025-07-31T07:13:41Z

/bot run

tensorrt-cicd · 2025-07-31T07:18:47Z

PR_Github #13630 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-31T08:43:41Z

PR_Github #13630 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10225 completed with status: 'FAILURE'

yiqingy0 · 2025-07-31T09:37:32Z

/bot run

tensorrt-cicd · 2025-07-31T09:42:42Z

PR_Github #13648 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-31T15:37:55Z

PR_Github #13648 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10243 completed with status: 'SUCCESS'

pcastonguay · 2025-08-07T17:11:10Z

@ZhanruiSunCh could you please review? Thx

Signed-off-by: Yiqing Yan <[email protected]>

pcastonguay · 2025-10-27T18:03:31Z

@yiqingy0 should this PR be closed? If not, let's get it merged if still needed.

coderabbitai bot requested review from ZhanruiSunCh, chzblych and niukuo July 29, 2025 08:30

yiqingy0 force-pushed the triton_trigger_rule branch from 48214fb to cedd795 Compare July 29, 2025 10:27

coderabbitai bot requested review from chuangz0 and pcastonguay July 30, 2025 03:17

yiqingy0 force-pushed the triton_trigger_rule branch from 517078a to fc23548 Compare July 30, 2025 07:42

pcastonguay approved these changes Jul 30, 2025

View reviewed changes

yiqingy0 force-pushed the triton_trigger_rule branch from a35e27b to e902c95 Compare July 31, 2025 07:13

yiqingy0 marked this pull request as ready for review August 1, 2025 01:53

yiqingy0 changed the title ~~Add triton trigger rules~~ [Infra][TRTLLM-5312] - Add triton trigger rules Aug 1, 2025

yiqingy0 changed the title ~~[Infra][TRTLLM-5312] - Add triton trigger rules~~ [TRTLLM-5312][infra] Add triton trigger rules Aug 1, 2025

yiqingy0 added 5 commits September 9, 2025 03:45

Add triton trigger rules

e82547f

Signed-off-by: Yiqing Yan <[email protected]>

test for only modify triton files

28542f0

Signed-off-by: Yiqing Yan <[email protected]>

test for modify triton and other files

ab21c86

Signed-off-by: Yiqing Yan <[email protected]>

test only modify pytorch files

943e059

Signed-off-by: Yiqing Yan <[email protected]>

remove test

91f499f

Signed-off-by: Yiqing Yan <[email protected]>

yiqingy0 force-pushed the triton_trigger_rule branch from a4ea3fd to 91f499f Compare September 9, 2025 03:47

yiqingy0 requested review from a team as code owners September 9, 2025 03:47

[TRTLLM-5312][infra] Add triton trigger rules #6440

Are you sure you want to change the base?

[TRTLLM-5312][infra] Add triton trigger rules #6440

Uh oh!

Conversation

yiqingy0 commented Jul 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

coderabbitai bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

yiqingy0 commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

yiqingy0 commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

yiqingy0 commented Jul 30, 2025

Uh oh!

yiqingy0 commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

yiqingy0 commented Jul 30, 2025

Uh oh!

yiqingy0 commented Jul 30, 2025

Uh oh!

yiqingy0 commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

yiqingy0 commented Jul 31, 2025

Uh oh!

yiqingy0 commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

yiqingy0 commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

yiqingy0 commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

yiqingy0 commented Jul 29, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 29, 2025 •

edited

Loading