[nvbug/5409417] Unwaive llava test case #6460

amukkara · 2025-07-29T21:30:38Z

reference outputs for llava test case (test_e2e.py::test_ptp_quickstart_multimodal[llava-v1.6-mistral-7b-llava-v1.6-mistral-7b-hf-image-False]) were fixed in #5994. This PR just unwavies the test case that passes on main after #5994.

Summary by CodeRabbit

Tests
- Re-enabled a previously skipped end-to-end test related to multimodal functionality.

coderabbitai · 2025-07-29T21:30:51Z

📝 Walkthrough

Walkthrough

A single test skip entry was removed from the integration test skip list. The entry pertained to the test case test_e2e.py::test_ptp_quickstart_multimodal[llava-v1.6-mistral-7b-llava-v1.6-mistral-7b-hf-image-False], which was previously skipped due to a referenced bug. No other changes were made.

Changes

Cohort / File(s)	Change Summary
Test skip list update `tests/integration/test_lists/waives.txt`	Removed skip entry for a specific test case related to a closed bug.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

test: [CI] remove closed bugs #6201: Removes multiple skip entries from the same file due to closed bugs, similar to this PR's removal of a single skip.
[test] Unwaive mistral3.1 small E2E test #6352: Removes a single test skip entry from the same file, directly related in scope and purpose.
test: [CI] remove closed bugs #6381: Removes skip entries for specific tests, including test_ptp_quickstart_multimodal, indicating close relevance.

Suggested reviewers

venkywonka
liji-nv
brb-nv
EmmaQiaoCh

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93b83e3 and 61d882c.

📒 Files selected for processing (1)

tests/integration/test_lists/waives.txt (0 hunks)

💤 Files with no reviewable changes (1)

tests/integration/test_lists/waives.txt

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

amukkara · 2025-07-29T21:34:38Z

/bot run

tensorrt-cicd · 2025-07-29T21:39:59Z

PR_Github #13422 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-29T22:52:53Z

PR_Github #13422 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10041 completed with status: 'FAILURE'

amukkara · 2025-07-29T23:33:35Z

/bot run

tensorrt-cicd · 2025-07-29T23:38:44Z

PR_Github #13433 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-30T00:54:58Z

PR_Github #13433 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10050 completed with status: 'FAILURE'

amukkara · 2025-07-30T01:00:12Z

/bot run

tensorrt-cicd · 2025-07-30T01:06:53Z

PR_Github #13447 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-30T08:35:33Z

PR_Github #13447 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10066 completed with status: 'FAILURE'

Signed-off-by: Anurag Mukkara <[email protected]>

amukkara · 2025-07-30T18:11:44Z

/bot skip --comment "x86 pipeline passed, SBSA failed but is disabled due to Blossom outage"

tensorrt-cicd · 2025-07-30T18:20:13Z

PR_Github #13570 [ skip ] triggered by Bot

tensorrt-cicd · 2025-07-30T18:38:45Z

PR_Github #13570 [ skip ] completed with state SUCCESS
Skipping testing for commit 61d882c

Signed-off-by: Anurag Mukkara <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>

Signed-off-by: Anurag Mukkara <[email protected]>

coderabbitai bot requested review from brb-nv, EmmaQiaoCh, liji-nv and venkywonka July 29, 2025 21:31

amukkara changed the title ~~[nvbugs/5409417] Unwaive llava test case~~ [nvbug/5409417] Unwaive llava test case Jul 29, 2025

amukkara requested a review from yechank-nvidia July 29, 2025 21:34

amukkara force-pushed the llava-accuracy branch from 9e148c2 to 93b83e3 Compare July 30, 2025 00:56

yechank-nvidia approved these changes Jul 30, 2025

View reviewed changes

Unwaive llava test

61d882c

Signed-off-by: Anurag Mukkara <[email protected]>

amukkara force-pushed the llava-accuracy branch from 93b83e3 to 61d882c Compare July 30, 2025 16:20

coderabbitai bot requested a review from yiqingy0 July 30, 2025 16:21

amukkara enabled auto-merge (squash) July 30, 2025 18:10

amukkara merged commit fac186e into NVIDIA:main Jul 30, 2025
3 checks passed

coderabbitai bot mentioned this pull request Aug 3, 2025

[None][fix] remove closed bugs #6576

Merged

lancelly pushed a commit to lancelly/TensorRT-LLM that referenced this pull request Aug 6, 2025

[nvbug/5409417] Unwaive llava test case (NVIDIA#6460)

bc34c2c

Signed-off-by: Anurag Mukkara <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>

coderabbitai bot mentioned this pull request Aug 6, 2025

[https://nvbugs/5385987][fix] Fix Qwen2 quantization issue by pinning transformers version #6673

Merged

jain-ria pushed a commit to jain-ria/TensorRT-LLM that referenced this pull request Aug 7, 2025

[nvbug/5409417] Unwaive llava test case (NVIDIA#6460)

cbac7c5

Signed-off-by: Anurag Mukkara <[email protected]>

This was referenced Aug 10, 2025

Draft: test: [CI] remove closed bugs #6769

Closed

[https://nvbugs/5444095][infra] waive test_ptp_quickstart_multimodal llava test #6795

Merged

[https://nvbugs/5375594][fix] fix oom issue on structural_tag test case #6838

Merged

amukkara deleted the llava-accuracy branch August 14, 2025 01:20

coderabbitai bot mentioned this pull request Aug 15, 2025

[None][ci] unwaive test_ptp_star_attention_example #6943

Merged

[nvbug/5409417] Unwaive llava test case #6460

[nvbug/5409417] Unwaive llava test case #6460

Uh oh!

Conversation

amukkara commented Jul 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

amukkara commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

amukkara commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

amukkara commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

amukkara commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

Uh oh!

Uh oh!

amukkara commented Jul 29, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 29, 2025 •

edited

Loading