[None][fix] fix kimi k2 serving and add test for Kimi-K2 #6589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughA new model, Changes
Sequence Diagram(s)sequenceDiagram
participant TestRunner
participant TestKimiK2
participant LLM
participant Tokenizer
TestRunner->>TestKimiK2: Run test_fp8_blockscale(...)
TestKimiK2->>LLM: Instantiate with FP8_BLOCK_SCALES quantization
LLM->>Tokenizer: decode_incrementally(...)
Tokenizer->>Tokenizer: Check _tokenizer attribute
alt Has _tokenizer
Tokenizer->>Tokenizer: Use hf_decode_incrementally
else
Tokenizer->>Tokenizer: Use trtllm_decode_incrementally
end
TestKimiK2->>LLM: Evaluate MMLU and GSM8K tasks
LLM-->>TestKimiK2: Return evaluation results
TestKimiK2-->>TestRunner: Assert quant_algo and test results
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
pengbowang-nv
force-pushed
the
dev-add-kimi-k2-test
branch
from
53d5282 to
8a0ca60
Compare
|
/bot run |
|
PR_Github #13938 [ run ] triggered by Bot |
|
PR_Github #13938 [ run ] completed with state |
pengbowang-nv
changed the title
pengbowang-nv
force-pushed
the
dev-add-kimi-k2-test
branch
from
441b42e to
70be182
Compare
|
/bot run |
|
PR_Github #14062 [ run ] triggered by Bot |
litaotju
reviewed
Aug 5, 2025
litaotju
approved these changes
Aug 5, 2025
Superjomn
approved these changes
Aug 5, 2025
|
PR_Github #14062 [ run ] completed with state |
Signed-off-by: Pengbo Wang <[email protected]>
Signed-off-by: Pengbo Wang <[email protected]>
pengbowang-nv
force-pushed
the
dev-add-kimi-k2-test
branch
from
70be182 to
9497b60
Compare
|
/bot reuse-pipeline |
|
PR_Github #14132 [ reuse-pipeline ] triggered by Bot |
|
PR_Github #14132 [ reuse-pipeline ] completed with state |
lancelly
pushed a commit
to lancelly/TensorRT-LLM
that referenced
this pull request
Aug 6, 2025
Signed-off-by: Pengbo Wang <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>
jain-ria
pushed a commit
to jain-ria/TensorRT-LLM
that referenced
this pull request
Aug 7, 2025
Signed-off-by: Pengbo Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
moonshotai/Kimi-K2-Instructmodel with FP8 block scales quantization.moonshotai/Kimi-K2-Instructmodel, including accuracy and latency checks.blobfilepackage as a new dependency.Description
Modify incremental detokenization for models that doesn't have fast tokenizer impl (affecting kimi k2).
Add
blobfileas a dependency required by the tokenizer of Kimi-K2.Add Kimi-K2 model MMLU and GSM8K test to safeguard accuracy. The test is also added to QA test list.
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.