[https://nvbugs/5433545][fix] TestPhi4MiniInstruct::test_auto_dtype - Use max_seq_len=4096 to fallback to the short RoPE factor #6895
Conversation
📝 WalkthroughWalkthroughIn tests/integration/defs/accuracy/test_llm_api_pytorch.py, the test TestPhi4MiniInstruct.test_auto_dtype updates the LLM initialization to explicitly pass max_seq_len=4096. The test flow and evaluated datasets remain unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/bot run |
|
PR_Github #15254 [ run ] triggered by Bot |
|
PR_Github #15254 [ run ] completed with state |
|
/bot run |
|
PR_Github #15263 [ run ] triggered by Bot |
|
/bot kill |
|
@syuoni , are those two score drops need to be further investigated? |
|
PR_Github #15337 [ kill ] triggered by Bot |
|
PR_Github #15337 [ kill ] completed with state |
|
/bot run |
|
PR_Github #15338 [ run ] triggered by Bot |
|
PR_Github #15338 [ run ] completed with state |
|
/bot run |
|
PR_Github #15458 [ run ] triggered by Bot |
|
PR_Github #15458 [ run ] completed with state |
|
/bot run |
|
PR_Github #15472 [ run ] triggered by Bot |
|
PR_Github #15472 [ run ] completed with state |
|
/bot run |
|
PR_Github #15487 [ run ] triggered by Bot |
|
PR_Github #15487 [ run ] completed with state |
moraxu
force-pushed
the
dev-mguzek-update-phi4m-mmlu-accuracy
branch
from
7b2ec2b to
2a4c239
Compare
|
/bot run |
Signed-off-by: Michal Guzek <[email protected]>
moraxu
force-pushed
the
dev-mguzek-update-phi4m-mmlu-accuracy
branch
from
2a4c239 to
57f82eb
Compare
|
/bot run |
|
PR_Github #15645 [ run ] triggered by Bot |
|
PR_Github #15645 [ run ] completed with state |
|
/bot run |
|
PR_Github #15658 [ run ] triggered by Bot |
|
PR_Github #15658 [ run ] completed with state |
|
/bot run |
|
What is the cause of this drop? Why are we adjusting the expected score instead of fixing the drop? |
|
PR_Github #15716 [ run ] triggered by Bot |
I just narrowed it down to this PR #6353, still going over it for more context. This PR just aims to fix failing CI, rather than completely skipping the test. |
|
PR_Github #15716 [ run ] completed with state |
Signed-off-by: Michal Guzek <[email protected]>
moraxu
changed the title
|
/bot skip |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand.
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --skip-test |
|
PR_Github #15824 [ run ] triggered by Bot |
|
PR_Github #15824 [ run ] completed with state |
|
Force merging since this test is not part of L0 yet, and the change is in line with others done in #6353. Using long rope is expected to cause accuracy degradation and limiting to 4k recovers the accuracy in this case. |
… Use max_seq_len=4096 to fallback to the short RoPE factor (#6895) Signed-off-by: Michal Guzek <[email protected]>
… Use max_seq_len=4096 to fallback to the short RoPE factor (NVIDIA#6895) Signed-off-by: Michal Guzek <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
… Use max_seq_len=4096 to fallback to the short RoPE factor (NVIDIA#6895) Signed-off-by: Michal Guzek <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
… Use max_seq_len=4096 to fallback to the short RoPE factor (NVIDIA#6895) Signed-off-by: Michal Guzek <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
… Use max_seq_len=4096 to fallback to the short RoPE factor (NVIDIA#6895) Signed-off-by: Michal Guzek <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
… Use max_seq_len=4096 to fallback to the short RoPE factor (NVIDIA#6895) Signed-off-by: Michal Guzek <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
5 participants
Description
TestPhi4MiniInstruct::test_auto_dtype- [https://nvbugs/5433545][fix] TestPhi4MiniInstruct::test_auto_dtype - Use max_seq_len=4096 to fallback to the short RoPE factor as per the #6353Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit