[None][ci] move some tests of b200 to post merge #7093
Conversation
Signed-off-by: junq <[email protected]>
📝 WalkthroughWalkthroughAdds a new B200 PCIe PyTorch post-merge test config in Jenkins and reorganizes the l0_b200 test matrix: prunes several pre-merge PyTorch NVFP4 entries, removes prior TRT/triton post-merge tests, and introduces a comprehensive PyTorch post-merge block gated for 1-GPU B100-matching systems on Ubuntu. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Commit (post-merge)
participant Jenkins as Jenkins L0_Test
participant Matrix as l0_b200 Test Matrix
participant Filter as Gating (gpu/os/backend)
participant Runner as Test Executor
Dev->>Jenkins: Trigger post-merge pipeline
Jenkins->>Matrix: Load x86TestConfigs["B200_PCIe-PyTorch-Post-Merge-1"]
Matrix->>Filter: Apply gates (gpu_count=1, "*b100*", ubuntu*, backend=pytorch, stage=post_merge)
Filter-->>Matrix: Eligible PyTorch test list
loop Split(1/1)
Matrix->>Runner: Spawn test job(s)
Runner-->>Jenkins: Report results
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
tests/integration/test_lists/test-db/l0_b200.yml (2)
113-116: Clarify why B200 tests are gated on 'b100' GPU wildcardTo avoid confusion for future maintainers (file is l0_b200 but hardware selector is b100), add a brief comment explaining that B200 PCIe tests currently run on the B100-TS2 pool.
wildcards: gpu: - '*b100*' linux_distribution_name: ubuntu* + # NOTE: B200 PCIe post-merge tests are executed on the B100-TS2 pool; hence the '*b100*' selector.
120-133: Large test matrix: sanity, but consider pruning or consolidating param combos if runtime becomes an issueThe enumerated DeepSeekV3Lite NVFP4 variants (CUTLASS/TRTLLM, mtp_nextn={0,2}, fp8kv={False,True}, attention_dp={False,True}, cuda_graph and overlap_scheduler toggles) are comprehensive. If post-merge runtime/flake rate becomes a concern, consider:
- Removing near-duplicate combos with minimal signal, or
- Splitting heavy variants to a separate optional stage.
No change required now; callout for maintainability.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
jenkins/L0_Test.groovy(1 hunks)tests/integration/test_lists/test-db/l0_b200.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
tests/integration/test_lists/test-db/l0_b200.yml
🔇 Additional comments (2)
tests/integration/test_lists/test-db/l0_b200.yml (1)
107-119: Post-merge PyTorch gating looks correct; verify intent to keep Triton post-merge block alongside itThe new condition targets post-merge PyTorch on single-GPU Ubuntu nodes with GPU wildcard 'b100'. This aligns with the Jenkins stage you added. Note the Triton post-merge block (Lines 92–106) still exists; confirm this is intentional and that you want both Triton and PyTorch post-merge jobs for l0_b200.
jenkins/L0_Test.groovy (1)
1838-1838: New B200 PyTorch post-merge stage is wired correctlyThe stage name contains both "Post-Merge" and "PyTorch", so Mako opts resolve to stage=post_merge and backend=pytorch; GPU count defaults to 1 as expected. It maps to l0_b200, which now has a matching post-merge PyTorch condition. Looks good.
QiJune
changed the title
|
/bot run |
|
PR_Github #15910 [ run ] triggered by Bot |
|
/bot skip --comment "all single GPU tests pass" |
|
PR_Github #15958 [ skip ] triggered by Bot |
|
PR_Github #15910 [ run ] completed with state |
|
PR_Github #15958 [ skip ] completed with state |
Signed-off-by: junq <[email protected]> Signed-off-by: Yuxin <[email protected]>
4 participants
Summary by CodeRabbit
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.