[https://nvbugs/5480415][fix] Fix phi4mm multi-gpu test

[Wanli-Jiang]

• PR for main branch: [https://nvbugs/5480415][fix] Fix phi4mm multi-gpu test #7256

Summary by CodeRabbit

• Bug Fixes

  • Improved output parsing to reliably capture "Generated text" blocks whether enclosed in single or double quotes.

• Tests

  • Updated multimodal quickstart test expectations for gemma-3-27b-it and Phi-4-multimodal-instruct image outputs to match current results and stabilize tests.

• Chores

  • No changes to public APIs or exported entities; interfaces remain fully compatible.

Description

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[coderabbitai]

📝 Walkthrough

Walkthrough

Updates parse_output regex to accept Generated text blocks quoted with either single or double quotes and updates expected image-modality keyword lists in two integration tests (for gemma-3-27b-it and Phi-4-multimodal-instruct). No public APIs changed.

Changes

Cohort / File(s)

Summary of Changes

Test parsing & expectations tests/integration/defs/test_e2e.py

Changes parse_output to use a regex matching either single- or double-quoted Generated text blocks (Generated text: (['"])(.*?)\1, re.MULTILINE); updates expected image-modality keyword lists for test_ptp_quickstart_multimodal (gemma-3-27b-it) to ["natural","turbulent","dramatic","scene","wave"], ["image","famous","rock","granite","landmark"], ["traffic","moderate","heavy","flowing","cars"]; updates expected lists for test_ptp_quickstart_multimodal_2gpu (Phi-4-multimodal-instruct) to ["object","mountain","weather","clear","clouds"] and ["traffic","road","vehicles","cars","bus"].

Sequence Diagram(s)

sequenceDiagram
  participant Test as Integration Test
  participant Parser as parse_output

  Test->>Parser: parse_output(log)
  alt Found Generated text (single or double quotes)
    Parser->>Parser: Apply regex: Generated text: (['"])(.*?)\1  (re.MULTILINE)
    Parser-->>Test: Return extracted text blocks
  else No match
    Parser-->>Test: Return no extracts
  end
  Note over Test,Parser: Test validates extracted tokens against updated expectations

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• [TRTLLM-6308][feat] Support Aggregate mode for phi4-mm #6820 — Updates multimodal test expectations and regex parsing related to Phi-4 multimodal handling.

Suggested reviewers

• chang-l
• syuoni
• tijyojwad

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 638227a and 2e8a9af.

📒 Files selected for processing (1)

• tests/integration/defs/test_e2e.py (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/integration/defs/test_e2e.py

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

tests/integration/defs/test_e2e.py (1)

1702-1704: Unify the regex with a single, quote-agnostic pattern

Current fallback is fine, but you can simplify and make it more robust using a backreference to the opening quote; this removes the second search and avoids edge cases.

Apply within this block:

-            match = re.search(r"(Generated text: \'(.*?)\')", item,
-                              re.MULTILINE)
-            if match is None:
-                match = re.search(r'(Generated text: "(.*?)")', item,
-                                  re.MULTILINE)
+            match = re.search(r'(Generated text:\s*([\'"])(.*?)\2)', item)

And update the extraction a few lines below to reflect the new capture group index:

# line 1708
results.append(match.group(3))

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 877e1f4 and 5519a10.

📒 Files selected for processing (1)

• tests/integration/defs/test_e2e.py (2 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Code must target Python 3.8+
Indent Python code with 4 spaces; do not use tabs
Preserve module namespaces when importing; import modules/packages and access members via the module (e.g., from package.subpackage import foo; foo.SomeClass())
Python file names should be snake_case
Python class names should be PascalCase
Python functions/methods and local variables should be snake_case; variables beginning with a number should be prefixed with k_ (e.g., k_99th_percentile)
Global variables should be UPPER_SNAKE_CASE prefixed with G_ (e.g., G_MY_GLOBAL); constants should be UPPER_SNAKE_CASE
Avoid shadowing variables from outer scopes; initialize all externally visible members in init
Prefer docstrings for interfaces used outside a file; comments should be reserved for in-function or file-local interfaces
Use Google-style docstrings for classes and functions; attributes and variables may be documented inline with trailing string literals
Avoid reflection when simpler, explicit code suffices (e.g., avoid dict(**locals()) patterns)
In try/except, catch the narrowest exceptions possible
For duck-typing patterns, keep the try body minimal and move logic to else to avoid masking unrelated failures

Files:

• tests/integration/defs/test_e2e.py

**/*.{c,cc,cpp,cxx,h,hh,hpp,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA copyright header (current year) to all source files (.cpp, .h, .cu, .py, etc.)

Files:

• tests/integration/defs/test_e2e.py

🔇 Additional comments (1)

tests/integration/defs/test_e2e.py (1)

2583-2584: LGTM: Updated Phi-4-MM expected keywords align with single-/multi-GPU tests

The new keyword sets for “image” match the ones used in test_ptp_quickstart_multimodal_phi4mm and the relaxed 0.6 match ratio here. This should reduce flakiness across devices.

[Wanli-Jiang]

/bot run

[tensorrt-cicd]

PR_Github #16621 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #16621 [ run ] completed with state SUCCESS
/LLM/release-1.0/L0_MergeRequest_PR pipeline #320 completed with status: 'FAILURE'

[Wanli-Jiang]

/bot run

[tensorrt-cicd]

PR_Github #16664 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #16664 [ run ] completed with state SUCCESS
/LLM/release-1.0/L0_MergeRequest_PR pipeline #324 completed with status: 'SUCCESS'

[brb-nv]

LGTM.

[brb-nv]

LGTM.

[Wanli-Jiang]

/bot reuse-pipeline

[tensorrt-cicd]

PR_Github #16766 [ reuse-pipeline ] triggered by Bot

[tensorrt-cicd]

PR_Github #16766 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #16664 for commit 818b53c