[None][test] update nim and full test list #7468
Conversation
📝 WalkthroughWalkthroughReworks QA integration test lists. In llm_function_full.txt, removes many Gemma/GPT2/StarCoder/Mistral/Nemotron/Eagle/Medusa entries and adds Phi‑3.x and Qwen (Medusa/Eagle) focused tests. In llm_function_nim.txt, removes initial e2e/accuracy block and adds a broad, reorganized NIM test matrix across many models, quantizations, and modalities. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/test_lists/qa/llm_function_nim.txt (1)
1-153: Fix broken test list paths in llm_function_nim.txt
Automated validation flagged every entry in tests/integration/test_lists/qa/llm_function_nim.txt as referencing non-existent files—update each path to match the actual test file locations; no exact duplicates were found.
🧹 Nitpick comments (5)
tests/integration/test_lists/qa/llm_function_nim.txt (2)
40-41: Remove stray blank lines to keep the list compact.- -
87-88: Very long Nemotron accuracy runs — confirm scheduling.
TIMEOUT (240)implies heavy jobs; ensure they’re scheduled on the correct pool (GPU type, walltime) and won’t block nim CI.tests/integration/test_lists/qa/llm_function_full.txt (3)
33-34: Remove duplicate EXAONE entry.This line appears twice and will waste CI cycles.
examples/test_exaone.py::test_llm_exaone_1gpu[disable_weight_only-exaone_3.0_7.8b_instruct-float16-nb:4] TIMEOUT (90) -examples/test_exaone.py::test_llm_exaone_1gpu[disable_weight_only-exaone_3.0_7.8b_instruct-float16-nb:4] TIMEOUT (90)
202-202: Inline comment may confuse parsers — prefer separate comment line.-examples/test_internlm.py::test_llm_internlm2_7b_1node_1gpu[bfloat16-enable_context_fmha-enable_gemm_plugin-enable_attention_plugin-nb:2] # 5 mins +# 5 mins +examples/test_internlm.py::test_llm_internlm2_7b_1node_1gpu[bfloat16-enable_context_fmha-enable_gemm_plugin-enable_attention_plugin-nb:2]
560-573: Heavy E2E tests — keep after lighter suites and ensure resource tagging.Maintain ordering and correct GPU-tag routing to minimize contention.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
tests/integration/test_lists/qa/llm_function_full.txt(4 hunks)tests/integration/test_lists/qa/llm_function_nim.txt(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Filenames compiled into a target must be case-insensitively unique
Files:
tests/integration/test_lists/qa/llm_function_full.txttests/integration/test_lists/qa/llm_function_nim.txt
🧠 Learnings (2)
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
Applied to files:
tests/integration/test_lists/qa/llm_function_full.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
tests/integration/test_lists/qa/llm_function_full.txttests/integration/test_lists/qa/llm_function_nim.txt
🪛 LanguageTool
tests/integration/test_lists/qa/llm_function_nim.txt
[grammar] ~42-~42: There might be a mistake here.
Context: ...:1-tp:1-float16-bs:1-cpp_e2e:False-nb:1] examples/test_multimodal.py::test_llm_mu...
(QB_NEW_EN)
[grammar] ~43-~43: There might be a mistake here.
Context: ...:1-tp:1-float16-bs:8-cpp_e2e:False-nb:1] examples/test_multimodal.py::test_llm_mu...
(QB_NEW_EN)
[grammar] ~44-~44: There might be a mistake here.
Context: ...:1-tp:1-float16-bs:1-cpp_e2e:False-nb:1] examples/test_multimodal.py::test_llm_mu...
(QB_NEW_EN)
[grammar] ~45-~45: There might be a mistake here.
Context: ...:1-tp:2-float16-bs:1-cpp_e2e:False-nb:1] examples/test_multimodal.py::test_llm_mu...
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (6)
tests/integration/test_lists/qa/llm_function_nim.txt (2)
11-11: Confirm TIMEOUT units and CI stage budget alignment.
TIMEOUT values are interpreted in minutes by the test harness (90 → 90 min, 240 → 240 min); ensure these durations fit within your CI stage’s overall timeout budget.
37-39: Verified renamed Gemma_vswatests exist
Found intests/integration/defs/examples/test_gemma.py:
test_llm_gemma_1gpu_summary_vswaat line 202test_llm_hf_gemma_quantization_1gpu_vswaat line 91test_hf_gemma_fp8_base_bf16_multi_loraat line 423tests/integration/test_lists/qa/llm_function_full.txt (4)
574-597: CLI + PyTorch API coverage looks good.Having both flows is expected here and aligns with prior guidance.
639-662: Expanded Qwen/Phi EAGLE/Medusa coverage LGTM.Good breadth across model sizes and variants.
1-697: Correct cross-file validation script
- Fix the
comminvocation (process-substitution error) so duplicates betweenllm_function_full.txtandllm_function_nim.txtare actually detected.- Revise the “file existence” check: the entries are pytest IDs, not raw paths—either parse out the real file locations or adjust the base path used for lookup.
22-31: Match TIMEOUT to slowest CI pool SLA
In tests/integration/test_lists/qa/llm_function_full.txt (lines 22–31), TIMEOUT is set to 90; confirm this aligns with your slowest pool’s maximum allowable test walltime to avoid unexpected failures.
crazydemo
force-pushed
the
update_nim_list
branch
from
b82bf83 to
f0663fe
Compare
|
/bot run --skip-test |
|
PR_Github #17346 [ run ] triggered by Bot |
|
PR_Github #17346 [ run ] completed with state |
crazydemo
force-pushed
the
update_nim_list
branch
3 times, most recently
from
4f0a855 to
6a2a56d
Compare
|
/bot run --skip-test |
|
PR_Github #17480 [ run ] triggered by Bot |
|
PR_Github #17480 [ run ] completed with state |
StanleySun639
force-pushed
the
update_nim_list
branch
from
6a2a56d to
cebbf48
Compare
|
/bot skip --comment "txt change only" |
|
/bot run --skip-test |
|
PR_Github #17605 [ skip ] triggered by Bot |
|
PR_Github #17606 [ run ] triggered by Bot |
|
PR_Github #17605 [ skip ] completed with state |
|
PR_Github #17606 [ run ] completed with state |
Signed-off-by: Ivy Zhang <[email protected]>
Signed-off-by: Ivy Zhang <[email protected]>
Signed-off-by: Ivy Zhang <[email protected]>
StanleySun639
force-pushed
the
update_nim_list
branch
from
651f294 to
c93c4c3
Compare
|
/bot skip --comment "txt change only" |
|
PR_Github #17688 [ skip ] triggered by Bot |
|
PR_Github #17688 [ skip ] completed with state |
Signed-off-by: Ivy Zhang <[email protected]>
4 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.