Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Sep 25, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test suite to skip a specific accuracy test on A100 environments, improving CI stability and reducing false negatives.

@xinhe-nv xinhe-nv marked this pull request as ready for review September 26, 2025 02:07
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250925_LLM_FUNCTION_TEST_1407 branch from e9097db to ccd0943 Compare September 26, 2025 02:07
@xinhe-nv xinhe-nv enabled auto-merge (squash) September 26, 2025 02:07
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 26, 2025

📝 Walkthrough

Walkthrough

Added a skip entry in tests/integration/test_lists/waives.txt for accuracy/test_llm_api_pytorch.py::TestMistralSmall24B::test_auto_dtype under the full:A100 context, referencing an nvbugs link.

Changes

Cohort / File(s) Summary
Test waivers
tests/integration/test_lists/waives.txt
Add SKIP for full:A100: accuracy/test_llm_api_pytorch.py::TestMistralSmall24B::test_auto_dtype (with nvbugs reference).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is too brief and does not follow the repository template, as it lacks the required “## Description” narrative, “## Test Coverage” details, and the PR checklist confirmation. Please update the PR description to use the provided template by adding a detailed explanation under “## Description,” listing relevant tests under “## Test Coverage,” and confirming the checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly summarizes the primary change of adding failed test cases to the waiver file and follows the required “[None][chore]” tag format, matching the modified file and reflecting the intent of the pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d650320 and ccd0943.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
Learnt from: EmmaQiaoCh
PR: NVIDIA/TensorRT-LLM#7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
PR: NVIDIA/TensorRT-LLM#7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

349-349: Waiver entry matches existing pattern

Scope, test identifier, and nvbugs link align with the rest of waives.txt; no issues spotted.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20020 [ run ] triggered by Bot

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250925_LLM_FUNCTION_TEST_1407 branch from ccd0943 to 1e4990a Compare September 26, 2025 02:18
@tensorrt-cicd
Copy link
Collaborator

PR_Github #20020 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15078 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250925_LLM_FUNCTION_TEST_1407 branch from 1e4990a to 5a30b28 Compare September 26, 2025 05:11
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250925_LLM_FUNCTION_TEST_1407 branch from 5a30b28 to 6a085c3 Compare September 26, 2025 06:24
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20050 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20050 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #20020 (Partly Tested) for commit 6a085c3

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250925_LLM_FUNCTION_TEST_1407 branch from 6a085c3 to cc818e1 Compare September 26, 2025 07:16
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20061 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20061 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #20020 (Partly Tested) for commit cc818e1

@xinhe-nv xinhe-nv merged commit ba6ab62 into NVIDIA:main Sep 26, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20250925_LLM_FUNCTION_TEST_1407 branch September 26, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants