Skip to content

Conversation

@Tabrizian
Copy link
Member

@Tabrizian Tabrizian commented Sep 28, 2025

Summary by CodeRabbit

  • Tests
    • Re-enabled a set of previously skipped integration tests by removing waivers, increasing test coverage and confidence in existing functionality.
    • No changes to user-facing behavior or features; this update strictly improves the reliability of our test suite and validation process.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@Tabrizian
Copy link
Member Author

/bot run --only-multi-gpu-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 28, 2025

📝 Walkthrough

Walkthrough

Removed multiple SKIP entries from tests/integration/test_lists/waives.txt, reducing the set of waived integration tests. No additions or logic changes.

Changes

Cohort / File(s) Summary of Changes
Test waiver list
tests/integration/test_lists/waives.txt
Deleted several SKIP entries; no new lines added; only removals affecting which tests are skipped.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is just the unfilled repository template with placeholder comments and lacks any actual summary of the change, explanation of why the tests are being unwaived, or details on test coverage, so it does not meet the required structure or provide meaningful context. Please replace the template placeholders with a brief summary of the change and its rationale, describe how the adjustments affect testing, and list or reference the specific tests that verify the new behavior to complete the Description and Test Coverage sections.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “[None][fix] unwaive tests” correctly follows the repository’s template by including a ticket placeholder, a lowercase type, and a concise summary of the main change, which is removing waivers from tests; it clearly conveys the primary intent of the changeset without unnecessary detail or noise.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 563e588 and e00780f.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20177 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20177 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15214 (Partly Tested) completed with status: 'FAILURE'

@Tabrizian
Copy link
Member Author

/bot run --only-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20183 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20183 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15220 (Partly Tested) completed with status: 'FAILURE'

@Tabrizian
Copy link
Member Author

/bot run --only-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20287 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20287 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15298 (Partly Tested) completed with status: 'FAILURE'

@Tabrizian
Copy link
Member Author

/bot run --only-multi-gpu-test

@Tabrizian
Copy link
Member Author

Remove disagg related cases since it is covered in this PR by @pcastonguay: #8069

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20290 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20290 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #15301 (Partly Tested) completed with status: 'FAILURE'

@Tabrizian
Copy link
Member Author

/bot run --only-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20293 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20293 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15304 (Partly Tested) completed with status: 'FAILURE'

@Tabrizian
Copy link
Member Author

/bot run --only-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20415 [ run ] triggered by Bot

@Tabrizian Tabrizian requested a review from brb-nv September 30, 2025 22:29
@Tabrizian Tabrizian enabled auto-merge (squash) September 30, 2025 22:29
Copy link
Collaborator

@brb-nv brb-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20415 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15406 (Partly Tested) completed with status: 'FAILURE'

@Tabrizian
Copy link
Member Author

/bot run --stage-list "GB200-4_GPUs-PyTorch-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20427 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20427 [ run ] completed with state DISABLED
L0 testing is limited to prioritized users. User Tabrizian is not in the prioritized list. L0 testing cannot be triggered.

@pcastonguay pcastonguay self-requested a review October 1, 2025 14:59
Signed-off-by: Iman Tabrizian <[email protected]>
@Tabrizian
Copy link
Member Author

/bot run --stage-list "GB200-4_GPUs-PyTorch-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20471 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20471 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15436 (Partly Tested) completed with status: 'FAILURE'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants