Fix constraint on __optional::__emplace_from.
#1661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_Args` template parameter pack is currently not passed to the `__optional<_Tp>::__emplace_from` constraint that checks that the return-type of invoking `_Fn` with `_Args...` is `_Tp`.
ericniebler
approved these changes
Oct 8, 2025
|
/ok to test 0008025 |
|
nice catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_Argstemplate parameter pack is currently not passed to the__optional<_Tp>::__emplace_fromconstraint that checks that the return-type of invoking_Fnwith_Args...is_Tp.