Require one-based indexing in _check_dim
#1879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1879 +/- ##
=======================================
Coverage 88.15% 88.15%
=======================================
Files 120 120
Lines 30252 30252
=======================================
Hits 26670 26670
Misses 3582 3582 ☔ View full report in Codecov by Sentry. |
fingolfin
approved these changes
Oct 27, 2024
| end | ||
|
|
||
| function _check_dim(r::Int, c::Int, arr::AbstractMatrix{T}, transpose::Bool = false) where {T} | ||
| Base.require_one_based_indexing(arr) |
There was a problem hiding this comment.
Those are not official API. OTOH that hasn't stopped us is in other cases...
There was a problem hiding this comment.
They are in julia nightly. See JuliaLang/julia#56196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is too much code that directly accesses entries using numerical indices e.g. in
(::MatrixSpace)(::AbstractMatrix)