CSTACKEX-30 SAN Feign Client #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryag1201
requested review from
piyush5netapp,
rajiv-jain-netapp and
sandeeplocharla
| import java.net.URI; | ||
|
|
||
| @Lazy | ||
| @FeignClient(name = "SANClient", url = "", configuration = FeignConfiguration.class ) |
There was a problem hiding this comment.
this feign client has multiple resources like lun, iGroup, LunMap. All have different different URLs. So, kept empty bcz we can use the method level baseURL like below:
OntapResponse getLunResponse(URI baseURL, @RequestHeader("Authorization") String authHeader);
sandeeplocharla
pushed a commit
that referenced
this pull request
Oct 21, 2025
…ommits. # This is the 1st commit message: CSTACKEX-25: Basic class structure # This is the commit message #2: Add PrimaryStoragePool base code # This is the commit message #3: CSTACKEX-25: Create Volume code basic code added # This is the commit message #4: CSTACKEX-25: additional logic for Primary storage pool creation # This is the commit message #5: CSTACKEX-29 Cluster, SVM and Aggr Feign Client # This is the commit message #6: CSTACKEX-29 Added License Info # This is the commit message #7: CSTACKEX-29 Resolve Review Comments # This is the commit message #8: CSTACKEX-29 Resolve Style check issues � This is the commit message #9: CSTACKEX-29 Resolve Style check issues � This is the commit message #10: CSTACKEX-29 Resolve Precommits Issues # This is the commit message #11: CSTACKEX-29 Resolve Precommits Issues
rajiv-jain-netapp
approved these changes
Oct 22, 2025
| public enum OsTypeEnum { | ||
| hyper_v("hyper_v"), | ||
|
|
||
| linux("linux"), |
There was a problem hiding this comment.
How do we map 'kvm' here, to 'linux'? Also, shall we restrict this list to the one's that we would support for first drop?
There was a problem hiding this comment.
should be linux and also reduced the list
| public enum ProtocolEnum { | ||
| iscsi("iscsi"), | ||
|
|
||
| mixed("mixed"); |
There was a problem hiding this comment.
do we need mixed?
|
|
||
| PROTOCOL_ENDPOINT("protocol_endpoint"), | ||
|
|
||
| VVOL("vvol"); |
|
|
||
| OPENVMS("openvms"), | ||
|
|
||
| SOLARIS("solaris"), |
There was a problem hiding this comment.
here also, shall we restrict this list?
sandeeplocharla
approved these changes
Oct 22, 2025
piyush5netapp
pushed a commit
that referenced
this pull request
Oct 22, 2025
* CSTACKEX-30 SAN Feign Client * CSTACKEX-30 Fixed check style issues * CSTACKEX-30 Fixed review comments --------- Co-authored-by: Gupta, Surya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SAN Feign Client and Models
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?