Page Multiple Roles For Each Incident #2252
Description
Hi there,
We noticed a change in behavior from previous versions where we are able to fire pages to multiple roles per instance. (e.g. page both the Commander and the Liaison). After merging v20220310 I'm noticing two different behaviors where:
- It always only pages the Commander
- When the Commander have is the same person as the Liaison, the pagerduty service id can get overwritten from Commander's service to Liaison's service. (seems to happen in flows.py within incident_create_flow function)
example of overwrite
6053` ^[[32mslack_1 |^[[0m DEBUG:Col ('participant_role_id', 'participant_role_assumed_at', 'participant_r ole_renounced_at', 'participant_role_role', 'participant_role_participant_id', 'anon_1_participant_id'):/ usr/local/lib/python3.9/site-packages/sqlalchemy/log.py:debug:105
6054 ^[[32mslack_1 |^[[0m DEBUG:Row (1702, datetime.datetime(2022, 6, 2, 18, 34, 1, 358128), None, 'Incident Commander', 1170, 1170):/usr/local/lib/python3.9/site-packages/sqlalchemy/log.py:debug:105
6055 ^[[32mslack_1 |^[[0m DEBUG:Row (1703, datetime.datetime(2022, 6, 2, 18, 34, 2, 332127), None, 'Liaison', 1170, 1170):/usr/local/lib/python3.9/site-packages/sqlalchemy/log.py:debug:105
The service id now points at the Liaison's service
6067 ^[[32mslack_1 |^[[0m 2022-06-02 18:34:14,390 DEBUG sqlalchemy.engine.base.OptionEngine Col ('service_evergreen', 'service_evergreen_owner', 'service_evergreen_reminder_interval', 'service_evergreen_last_reminder_at', 'service_id', 'service_is_active', 'service_name', 'service_type', 'service_description', 'service_external_id', 'service_search_vector', 'service_project_id', 'service_created_at', 'service_updated_at')
6068 ^[[32mslack_1 |^[[0m 2022-06-02 18:34:14,390 DEBUG sqlalchemy.engine.base.OptionEngine Row (None, None, 90, datetime.datetime(2022, 1, 10, 17, 47, 37, 393480), 25, True, 'Product Incident Liaison', 'pagerduty-oncall', 'Liaison service for incidents handled by Product Support.', 'FAJIEWF', "'incid':2 'liaison':3 'product':1", 1, datetime.datetime(2022, 1, 14, 17, 46, 40, 896621), datetime.datetime(2022, 5, 20, 16, 28, 37, 423167))
My question would be is it possible to add the feature to page multiple roles or should we add in the feature ourselves and submit a pr upstream?