Fixes bug where incident role was not being displayed correctly when changed via the Web UI

src/dispatch/incident/flows.py

@@ -1133,13 +1133,14 @@ def incident_assign_role_flow(
                 "weblink": None,
             }
 
-        if incident.status != IncidentStatus.closed:
+        if incident.status != IncidentStatus.closed.value:
             # we send a notification to the incident conversation
             send_incident_new_role_assigned_notification(
                 assigner_contact_info, assignee_contact_info, assignee_role, incident, db_session
             )
 
-    if assignee_role == ParticipantRoleType.incident_commander:
+
+    if assignee_role == ParticipantRoleType.incident_commander.value:
         # we send a message to the incident commander with tips on how to manage the incident
         send_incident_management_help_tips_message(incident, db_session)
 

src/dispatch/incident/messaging.py

@@ -591,7 +591,9 @@ def send_incident_new_role_assigned_notification(
         db_session=db_session, project_id=incident.project.id, plugin_type="conversation"
     )
     if not plugin:
-        log.warning("Incident new role message not sent because no conversation plugin is enabled.")
+        log.warning(
+            "Incident new role assignment message not sent. No conversation plugin is enabled."
+        )
         return
 
     plugin.instance.send(

src/dispatch/incident/service.py

@@ -47,7 +47,7 @@ def assign_incident_role(
                         incident_description=incident.description,
                     )
 
-    elif role == ParticipantRoleType.liaison:
+    elif role == ParticipantRoleType.liaison.value:
         if incident.incident_type.liaison_service:
             service = incident.incident_type.liaison_service
             if oncall_plugin:

src/dispatch/incident/views.py

@@ -106,9 +106,9 @@ def create_incident(
         db_session=db_session, reporter_email=current_user.email, **incident_in.dict()
     )
 
-    if incident.status == IncidentStatus.stable:
+    if incident.status == IncidentStatus.stable.value:
         background_tasks.add_task(incident_create_stable_flow, incident_id=incident.id)
-    elif incident.status == IncidentStatus.closed:
+    elif incident.status == IncidentStatus.closed.value:
         background_tasks.add_task(incident_create_closed_flow, incident_id=incident.id)
     else:
         background_tasks.add_task(incident_create_flow, incident_id=incident.id)
@@ -151,7 +151,7 @@ def update_incident(
         current_user.email,
         incident_id=incident.id,
         assignee_email=incident_in.commander.individual.email,
-        assignee_role=ParticipantRoleType.incident_commander,
+        assignee_role=ParticipantRoleType.incident_commander.value,
     )
 
     # assign reporter
@@ -160,7 +160,7 @@ def update_incident(
         current_user.email,
         incident_id=incident.id,
         assignee_email=incident_in.reporter.individual.email,
-        assignee_role=ParticipantRoleType.reporter,
+        assignee_role=ParticipantRoleType.reporter.value,
     )
 
     return incident

src/dispatch/participant_role/flows.py

@@ -55,7 +55,7 @@ def assign_role_flow(
             add_role(
                 db_session=db_session,
                 participant_id=participant_with_assignee_role.id,
-                participant_role=ParticipantRoleType.participant,
+                participant_role=ParticipantRoleType.participant.value,
             )
 
         log.debug(
@@ -68,7 +68,7 @@ def assign_role_flow(
             db_session=db_session, participant_id=assignee_participant.id
         )
         for participant_active_role in participant_active_roles:
-            if participant_active_role.role == ParticipantRoleType.participant:
+            if participant_active_role.role == ParticipantRoleType.participant.value:
                 renounce_role(db_session=db_session, participant_role=participant_active_role)
                 break