This repository was archived by the owner on Sep 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 624
Confluence storage and document plugin #2940
Merged
mvilanova
merged 5 commits into
Netflix:master
from
Cinojose:enhancement/confluence_plugin
Feb 7, 2023
Merged
Confluence storage and document plugin #2940
mvilanova
merged 5 commits into
Netflix:master
from
Cinojose:enhancement/confluence_plugin
Feb 7, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvilanova
suggested changes
Feb 6, 2023
Contributor
mvilanova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Just minor stuff. I think there's an opportunity to have all the atlassian-related plugins (Jira and Confluence) under the same directory now and have all of them leverage (and extend if necessary) the config stuff such as HostingType and API related things. We could tackle it in a separate PR.
Contributor
|
Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to create a confluence plugin for both storage and document.
The plugin right now supports only cloud hosted confluence and can be extended down the road. Logs and sheets are not supported as confluence has no such concept. it make use of the atlassian-python-api for the confluence api calls.
I can create some screenshots on how it looks like, if there is a need. Please review.