Skip to content

Conversation

@fraxken
Copy link
Member

@fraxken fraxken commented Jul 16, 2025

No description provided.

@fraxken fraxken requested a review from Copilot July 16, 2025 18:07
@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2025

🦋 Changeset detected

Latest commit: 9862e3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nodesecure/js-x-ray Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fraxken fraxken requested a review from clemgbld July 16, 2025 18:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the probe system by moving signal constants from a separate export (ProbeSignals) into the probe's main context. The change improves API design by providing signals directly in the context object rather than requiring a separate import.

Key changes:

  • Moves ProbeSignals into ProbeRunner.Signals as a static property
  • Updates probe main function signatures to receive signals via context
  • Adds a new ProbeMainContext type that extends ProbeContext with signals and data

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/ProbeRunner.ts Moves ProbeSignals to static Signals property and updates type definitions
test/utils/index.ts Updates test probe to use signals from context instead of imported ProbeSignals
test/ProbeRunner.spec.ts Updates all test cases to use ProbeRunner.Signals instead of ProbeSignals
src/probes/*.ts Updates all probe implementations to use signals from context parameter
docs/AstAnalyser.md Updates documentation example to reflect new API
.changeset/pretty-moose-go.md Adds changeset for the refactoring

@fraxken fraxken merged commit f66af80 into master Jul 16, 2025
6 checks passed
@fraxken fraxken deleted the probe-runner-signals branch July 16, 2025 18:26
@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants