fix(js-x-ray): properly deep clone and reset probe context in ProbeRunner #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e6feab6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with probe context management in the ProbeRunner class by implementing proper deep cloning and context reset functionality. The changes ensure that probe contexts are isolated and properly restored after execution.
- Implements deep cloning of probe contexts using
structuredClone()to prevent mutation of original contexts - Adds context reset functionality to restore probe contexts to their original state after finalization
- Updates type definitions to improve clarity between probe context and initialization context
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| workspaces/js-x-ray/src/ProbeRunner.ts | Implements deep cloning logic, adds symbol for original context storage, and updates context reset in finalize method |
| workspaces/js-x-ray/test/ProbeRunner.spec.ts | Adds comprehensive test case to verify deep cloning and context reset behavior |
| .changeset/ninety-adults-shout.md | Documents the fix in changeset for release notes |
clemgbld
approved these changes
Jul 18, 2025
fraxken
force-pushed
the
proberunner-ctx-preserve
branch
from
d51a3ca to
fbc0b0e
Compare
…nner Update workspaces/js-x-ray/test/ProbeRunner.spec.ts Co-authored-by: Copilot <[email protected]>
fraxken
force-pushed
the
proberunner-ctx-preserve
branch
from
fbc0b0e to
e6feab6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.