Abandon usage of ndep in input files, always read NHx and NOy #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
JorgSchwinger
approved these changes
Feb 12, 2025
Contributor
JorgSchwinger
left a comment
JorgSchwinger
left a comment
There was a problem hiding this comment.
Thanks for this - looks good!
| ndep(i,j,idepnhx) = nhxdepread(i,j) | ||
| else | ||
| ndep(i,j,idepnoy) = ndepread(i,j) | ||
| ndep(i,j,idepnoy) = noydepread(i,j) + nhxdepread(i,j) |
Contributor
There was a problem hiding this comment.
I think the ndep = 0.0 in line 203 should be moved up to the start of the routine (could then also be removed in line 189). Currently it is only set to zero for use_nuopc_ndep=.true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @TomasTorsvik and @JorgSchwinger ,
with this PR, we abandon the usage of
ndepin N-deposition input files. From now on, NOy and NHx are always read and used (and in case of the current default, just added together). The newly generated input files for N-deposition are prepared to support the old and new version, while as written before, one cannot expect bfb.