Skip to content

Improve the way to find Enzyme. #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2025
Merged

Improve the way to find Enzyme. #48

merged 3 commits into from
Feb 10, 2025

Conversation

@nkoukpaizan
Copy link
Collaborator

@nkoukpaizan nkoukpaizan commented Jan 27, 2025

This improves the method to find Enzyme and related libraries via CMake.

Should fix #47

@nkoukpaizan nkoukpaizan self-assigned this Jan 27, 2025
@pelesh
Copy link
Collaborator

pelesh commented Jan 28, 2025

CC @ashermancinelli

@shakedregev
Copy link
Collaborator

shakedregev commented Jan 28, 2025 •
edited
Loading 

[ 88%] Running Enzyme opt pass on target EnzymeStandaloneCheck
LLVM ERROR: Could not load library '/opt/homebrew/Cellar/llvm/19.1.7/lib': dlopen(/opt/homebrew/Cellar/llvm/19.1.7/lib, 0x0009): tried: '/opt/homebrew/Cellar/llvm/19.1.7/lib' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/Cellar/llvm/19.1.7/lib' (no such file), '/opt/homebrew/Cellar/llvm/19.1.7/lib' (not a file)

make[2]: *** [examples/Enzyme/Standalone/EnzymeStandaloneCheck_enzyme.ll] Error 1
make[1]: *** [examples/Enzyme/Standalone/CMakeFiles/EnzymeStandaloneCheck_target.dir/all] Error 2

Can you let me know what I should change my ccmake variables to? It's not like before this I was able to build with Enzyme, but presumably the point was to make this easier.

shakedregev
shakedregev approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@shakedregev shakedregev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass

@pelesh pelesh merged commit 88cecaa into develop Feb 10, 2025
2 checks passed
pelesh pushed a commit that referenced this pull request Apr 14, 2025
@nkoukpaizan @pelesh
Improve the way to find Enzyme. (#48)
c26bd6f 
* Improve the way to find Enzyme.

* Add missing 'REQUIRED' argument to find_library.

* Explicitly look for .dylib and .dll in addition to .so. Not providing an extension does not seem to work for Enzyme plugin.
@nkoukpaizan nkoukpaizan deleted the nicholson/improve-findEnzyme branch May 13, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shakedregev shakedregev shakedregev approved these changes

@pelesh pelesh Awaiting requested review from pelesh

Assignees

@nkoukpaizan nkoukpaizan

Labels

cmake

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issues building with Enzyme

4 participants

@nkoukpaizan @pelesh @shakedregev