Skip to content

Conversation

@treydock
Copy link
Collaborator

@treydock treydock commented Oct 6, 2022

Fixes #114

@treydock treydock added the enhancement New feature or request label Oct 6, 2022
@johrstrom
Copy link
Contributor

I can't tell if this has logic to remove node 12. puppet's much better at keeping state that ansible, so maybe the 14 update replaces 12 outright?

I ask because I'm upgrading the ansible role for the same and I want to catch the case where 12 is installed and needs to be removed before installing 14 (IDK if yum and apt will take care of the removal automatically).

@treydock
Copy link
Collaborator Author

treydock commented Nov 9, 2022

This module won't remove unused packages. For RHEL7 the NodeJS packages for 14 install parallel to 12, and that's only OS where there would be any cleanup but historically have left cleanup to admins be done manually. For DNF based OSes, the nodejs:14 module will replace packages in nodejs:12 module via DNF commands executed by Puppet when switch versions (same steps in OSC/ood-documentation#730). For Ubuntu it's a straight upgrade during update of OnDemand so no old packages left behind.

@treydock treydock force-pushed the nodejs14 branch 14 times, most recently from 7bda33e to 08e8008 Compare November 15, 2022 19:34
@treydock treydock merged commit e9559f2 into master Nov 15, 2022
@treydock treydock deleted the nodejs14 branch November 15, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[release_2.0] Upgrade to NodeJS 14

2 participants