Skip to content

Conversation

@david-driscoll
Copy link
Member

Fixes #455

Resolve providers don't technically link to their parents registration options, but they do link to the capability. This change fixes that relationship.

@david-driscoll david-driscoll added the bug Something isn't working label Dec 5, 2020
@github-actions github-actions bot added this to the v0.19.0 milestone Dec 5, 2020
@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #459 (53bc04b) into master (60ebb3a) will decrease coverage by 0.09%.
The diff coverage is 7.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   71.44%   71.34%   -0.10%     
==========================================
  Files         251      251              
  Lines       11892    11907      +15     
  Branches      812      810       -2     
==========================================
- Hits         8496     8495       -1     
- Misses       3396     3412      +16     
Impacted Files Coverage Δ
src/JsonRpc.Generators/Helpers.cs 61.81% <0.00%> (-1.16%) ⬇️
...tMethodGeneratorWithRegistrationOptionsStrategy.cs 48.11% <0.00%> (-0.42%) ⬇️
...thodGeneratorWithoutRegistrationOptionsStrategy.cs 100.00% <ø> (ø)
...thodGeneratorWithoutRegistrationOptionsStrategy.cs 0.00% <ø> (ø)
...er/Configuration/DidChangeConfigurationProvider.cs 81.45% <100.00%> (+0.53%) ⬆️
src/Shared/SupportedCapabilities.cs 78.88% <100.00%> (ø)
src/Shared/LspRequestRouter.cs 100.00% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ebb3a...53bc04b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in IColorPresentationHandler

1 participant