Skip to content

Conversation

@Drezil
Copy link
Contributor

@Drezil Drezil commented Jan 8, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Implemented fix for #1849

@wing328
Copy link
Member

wing328 commented Jan 8, 2019

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@Drezil
Copy link
Contributor Author

Drezil commented Jan 8, 2019

Oh. Forgot to add that email-address to my profile. Fixed now. Thanks for the notice.

@wing328
Copy link
Member

wing328 commented Jan 9, 2019

cc @jonschoning @algas

@wing328 wing328 added this to the 4.0.0 milestone Jan 9, 2019
@wing328
Copy link
Member

wing328 commented Feb 20, 2019

Build passed locally:

➜  haskell-servant git:(Drezil-master) stack test
openapi-petstore-0.1.0.0: configure (lib)
Configuring openapi-petstore-0.1.0.0...
clang: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]
openapi-petstore-0.1.0.0: build (lib)
Preprocessing library for openapi-petstore-0.1.0.0..
Building library for openapi-petstore-0.1.0.0..
[1 of 2] Compiling OpenAPIPetstore.Types ( lib/OpenAPIPetstore/Types.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/OpenAPIPetstore/Types.o )
[2 of 2] Compiling OpenAPIPetstore.API ( lib/OpenAPIPetstore/API.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/OpenAPIPetstore/API.o )
openapi-petstore-0.1.0.0: copy/register
Installing library in /Users/williamcheng/Code/openapi-generator/samples/server/petstore/haskell-servant/.stack-work/install/x86_64-osx/lts-12.18/8.4.4/lib/x86_64-osx-ghc-8.4.4/openapi-petstore-0.1.0.0-HC9DnrEnAtD3ME0hmTe0rs
Registering library for openapi-petstore-0.1.0.0..

@wing328 wing328 merged commit ae376c1 into OpenAPITools:master Feb 20, 2019
@wing328 wing328 changed the title Something in the dependencies changed. This switch is no longer needed. [Haskell][Servant] Remove switch that is no longer needed due to dependency change Feb 20, 2019
jimschubert added a commit that referenced this pull request Feb 23, 2019
* master: (40 commits)
  [Python] remove default value from being fallback to example (#2213)
  Add petstore integration tests to Ruby OAS3 client (#2211)
  Gradle - make GenerateTask properties optional (#2185)
  skip bats installation (#2198)
  Something in the dependencies changed. This switch is no longer needed. (#1850)
  Use oauth token for basic bearer auth in Rust. (#2161)
  Fix missing nullable (#2189)
  Enable error handling in Java WebClient library, fixes #1243 (#1244)
  [core] fix referenced enum case (#2175)
  rest-template: allow array parameters in path using collectionFormat (#2177)
  update go petstore samples
  Fix string types for cpprestsdk client generator (#1676)
  update kotline samples
  Remove API Key Authentication code for go when cookie is used. (#1601)
  changed the package install instructions to install the .tgz package … (#1989)
  okhttp-gson: allow array parameters in path using collectionFormat (#2137)
  [Ruby] Fix regualr expression in error message (#2069) (#2139)
  [kotlin][client] bytearray conversion (#2166)
  [rust-server] Added client documentation to rust-server (#2159)
  [Java] Getter/Setter naming convention not followed in generated models (#2095)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants