Add Dockerfile templating capability #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaur Palang <[email protected]>
Signed-off-by: Kaur Palang <[email protected]>
kpalang
requested review from
a team,
gibson9583,
jonbartels,
kayyagari and
tonygermano
and removed request for
a team
kpalang
force-pushed
the
feature/templated-dockerfiles
branch
from
889a82d to
4ed4d20
Compare
Signed-off-by: Kaur Palang <[email protected]>
kpalang
force-pushed
the
feature/templated-dockerfiles
branch
from
4ed4d20 to
ea559ac
Compare
|
Can you show some other projects that use this same strategy? |
The official postgres image uses template rendering, although not with |
|
Adding this to leave a trace behind, good conversation going on in this thread in Discord. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds templating capabilities to render a
Dockerfileand an accompanyingcompose.yamlfor each OIE release.To render the files ensure you have installed
gomplate. Then run the./render_docker_images.shscript from repository root.To build the images, run the following command from repo root, replacing the
4.5.2-tp.1with your desired version number.docker compose -f dockerfiles/4.5.2-tp.1/compose.yaml build --build-arg CREATED_AT=$(date -u +"%Y-%m-%dT%H:%M:%SZ")