Skip to content

Added some dev tools & code sniffers #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Fixed "if newsletter module disabled, customer backend would blank without notice"
merged 5 commits into from
Aug 17, 2022
Merged

Added some dev tools & code sniffers #2400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3de76e2
Added some dev tool & code sniffers
sreichel Aug 10, 2022
925260c
Support php7.2+
sreichel Aug 10, 2022
515afb5
Fixed typo
sreichel Aug 14, 2022
bfb2995
Updated composer.lock
sreichel Aug 14, 2022
f61d678
Merge branch '1.9.4.x' into composer-dev-tools
sreichel Aug 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,25 @@
"magento-hackathon/magento-composer-installer": "^3.1 || ^2.1 || ^4.0"
},
"require-dev": {
"friendsofphp/php-cs-fixer": ">=3.4",
"macopedia/phpstan-magento1": "^1.0.4",
"phpstan/phpstan": "^1.8"
"magento-ecg/coding-standard": "^4.4",
"phpcompatibility/php-compatibility": "^9.3",
"phpmd/phpmd": "^2.12",
"phpstan/phpstan": "^1.8",
"squizlabs/php_codesniffer": "^3.7"
},
"scripts": {
"set-phpcs-paths": [
"[ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths vendor/phpcompatibility/php-compatibility,vendor/magento-ecg/coding-standard",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way not to hardcode vendor?

Copy link
Contributor Author

@sreichel sreichel Aug 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried with COMPOSER_VENDOR_DIR ....

... if you set COMPOSER_VENDOR_DIR as ENV variable it works ...

ddev config.yaml:

web_environment: [
  COMPOSER_VENDOR_DIR=test
]

composer.json

    "set-phpcs-paths": [
      "[ $COMPOSER_DEV_MODE -eq 0 ] || $COMPOSER_VENDOR_DIR/bin/phpcs --config-set installed_paths $COMPOSER_VENDOR_DIR/phpcompatibility/php-compatibility,$COMPOSER_VENDOR_DIR/magento-ecg/coding-standard",
      "[ $COMPOSER_DEV_MODE -eq 0 ] || $COMPOSER_VENDOR_DIR/bin/phpcs -i"
    ],

Having custom vendor dir is an edge case ... i'd not change it.

Edit:

  • set vendor-dir in composer.json is not required in this case
  • set vendor-dir in composer.json DOES NOT set COMPOSER_VENDOR_DIR

"[ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs -i"
],
"post-install-cmd": [
"@set-phpcs-paths"
],
"post-update-cmd": [
"@set-phpcs-paths"
]
},
"conflict": {
"n98/n98_layouthelper": "*"
Expand Down
Loading