-
-
Notifications
You must be signed in to change notification settings - Fork 452
Phpstan update #2693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Phpstan update #2693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Going to split this for easier review ... |
# Conflicts: # lib/Varien/Cache/Backend/Eaccelerator.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Admin
Relates to Mage_Admin
Component: Adminhtml
Relates to Mage_Adminhtml
Component: AdminNotification
Relates to Mage_AdminNotification
Component: Api2
Relates to Mage_Api2
Component: Backup
Relates to Mage_Backup
Component: Bundle
Relates to Mage_Bundle
Component: Catalog
Relates to Mage_Catalog
Component: CatalogIndex
Relates to Mage_CatalogIndex
Component: CatalogInventory
Relates to Mage_CatalogInventory
Component: CatalogSearch
Relates to Mage_CatalogSearch
Component: Centinel
Relates to Mage_Centinel
Component: Core
Relates to Mage_Core
Component: CurrencySymbol
Relates to Mage_CurrencySymbol
Component: Customer
Relates to Mage_Customer
Component: Directory
Relates to Mage_Directory
Component: Downloadable
Relates to Mage_Downloadable
Component: Eav
Relates to Mage_Eav
Component: ImportExport
Relates to Mage_ImportExport
Component: Index
Relates to Mage_Index
Component: Install
Relates to Mage_Install
Component: lib/Mage
Relates to lib/Mage
Component: lib/Varien
Relates to lib/Varien
Component: lib/*
Relates to lib/*
Component: Log
Relates to Mage_Log
Component: Media
Relates to Mage_Media
Component: Payment
Relates to Mage_Payment
Component: PayPal
Relates to Mage_Paypal
Component: PaypalUk
Relates to Mage_PaypalUk
Component: ProductAlert
Relates to Mage_ProductAlert
Component: Reports
Relates to Mage_Reports
Component: Rule
Relates to Mage_Rule
Component: Sales
Relates to Mage_Sales
Component: SalesRule
Relates to Mage_SalesRule
Component: Shipping
Relates to Mage_Shipping
Component: Tax
Relates to Mage_Tax
Component: Uploader
Relates to Mage_Uploader
Component: Usa
Relates to Mage_Usa
Component: Weee
Relates to Mage_Weee
Component: Wishlist
Relates to Mage_Wishlist
composer
Relates to composer.json
environment
Mage.php
Relates to app/Mage.php
phpstan
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
Last commit changed phpstan level from 3 to 5. Level 6 isn't possible b/c missing typehints.
Cons:
Pro
Contribution checklist (*)