Skip to content

Phpstan update #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 89 commits into from
Closed

Phpstan update #2693

wants to merge 89 commits into from

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 8, 2022 •
edited
Loading

Description

  • several phpstan fixes
  • updadet phpstan to 1.9.2
  • updated workflow
  • added to default checks
    • app/code/core/Mage/Centinel
    • app/code/core/Mage/PaypalUk
    • app/code/core/Mage/Use
    • app/code/core/Mage/Weee
    • lib/Mage
    • lib/Magento
    • lib/Varien
  • some CS-fixes (sorry)
    • lib/Mage
    • lib/Magento
    • lib/Varien

Note

Last commit changed phpstan level from 3 to 5. Level 6 isn't possible b/c missing typehints.

Cons:

  • huge baseline file

Pro

  • all fixable errors listed
  • checks should complete faster w/o experimental check

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

sreichel added 18 commits November 8, 2022 03:20
@sreichel
Fix: Mage_Uploader
ede6eb8
@sreichel
Fix: Mage_Catalog_Model_Product_Image::_getMemoryLimit()
dc20ec8
@sreichel
Fix: remove default value, updated phpdocs
985ce13
@sreichel
Fix: Mage_Payment_Model_Method_Cc::validateCcNum()
59d8373
@sreichel
Fix: Mage_SalesRule_Model_Resource_Coupon_Usage::updateCustomerCoupon…
5e86f18 
…TimesUsed()
@sreichel
Fix: Mage_Adminhtml_Block_Tax_Rate_Grid_Renderer_Data::_getValue()
71c4e94
@sreichel
Fix: Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Number::_getVal…
402ed17 
…ue()
@sreichel
Fix: Mage_Catalog_Model_Resource_Product_Indexer_Price::catalogProduc…
3f73204 
…tMassAction()
@sreichel
Fix: Mage_CatalogInventory_Model_Resource_Indexer_Stock::catalogProdu…
702b962 
…ctMassAction()
@sreichel
Fix: Mage_Core_Model_Date...
654c08c
@sreichel
Fix: Mage_Eav_Model_Entity_Setup
7baa49a
@sreichel
Updated phpstan to v1.9.1
e459410
@sreichel
Fix: Mage_ImportExport_Model_Import::expandSource()
469a7dc
@sreichel
Fix: Mage_Log_Model_Resource_Log
0ce0c30
@sreichel
Fix: Mage_Catalog_Model_Resource_Layer_Filter_Price
9492233
@sreichel
Fix: Mage_CatalogIndex_Model_Resource_Price
d50d290
@sreichel
Fix: Mage_Core_Model_Design_Package
1855a3d
@sreichel
Fix: Mage_Core_Model_Resource_Setup_Query_Modifier
4203e26
@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogIndex Relates to Mage_CatalogIndex Component: Core Relates to Mage_Core Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: Log Relates to Mage_Log Component: Payment Relates to Mage_Payment Component: SalesRule Relates to Mage_SalesRule Component: Uploader Relates to Mage_Uploader composer Relates to composer.json labels Nov 8, 2022
@sreichel sreichel changed the title Phpstan fixes Phpstan update Nov 12, 2022
@sreichel sreichel marked this pull request as draft November 14, 2022 22:28
@sreichel
Copy link
Contributor Author

sreichel commented Nov 14, 2022

Going to split this for easier review ...

@sreichel sreichel mentioned this pull request Nov 14, 2022
Closed
4 tasks
@github-actions github-actions bot added Component: AdminNotification Relates to Mage_AdminNotification Component: Downloadable Relates to Mage_Downloadable Component: lib/Zend Component: Wishlist Relates to Mage_Wishlist Mage.php Relates to app/Mage.php labels Nov 14, 2022
@sreichel
Merge branch '1.9.4.x' into phpstan-daily
faca153 
# Conflicts:
#	lib/Varien/Cache/Backend/Eaccelerator.php
@sreichel sreichel requested review from elidrissidev and fballiano and removed request for elidrissidev and fballiano November 19, 2022 22:08
@sreichel sreichel closed this Nov 22, 2022
@sreichel sreichel deleted the phpstan-daily branch November 22, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmotyl tmotyl tmotyl left review comments

@kiatng kiatng kiatng left review comments

Assignees

No one assigned

Labels

Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: AdminNotification Relates to Mage_AdminNotification Component: Api2 Relates to Mage_Api2 Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Core Relates to Mage_Core Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: Install Relates to Mage_Install Component: lib/Mage Relates to lib/Mage Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Log Relates to Mage_Log Component: Media Relates to Mage_Media Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: PaypalUk Relates to Mage_PaypalUk Component: ProductAlert Relates to Mage_ProductAlert Component: Reports Relates to Mage_Reports Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Shipping Relates to Mage_Shipping Component: Tax Relates to Mage_Tax Component: Uploader Relates to Mage_Uploader Component: Usa Relates to Mage_Usa Component: Weee Relates to Mage_Weee Component: Wishlist Relates to Mage_Wishlist composer Relates to composer.json environment Mage.php Relates to app/Mage.php phpstan

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sreichel @tmotyl @kiatng