Skip to content

phpstan: Change OpenMage version compare #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2022
Merged

phpstan: Change OpenMage version compare #2839

merged 1 commit into from
Dec 23, 2022

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 23, 2022 •
edited
Loading

Description (*)

... to work with v19 and v20.

  1. See Merge v19 -> v20 #2766

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@sreichel sreichel requested a review from fballiano December 23, 2022 19:52
@github-actions github-actions bot added Mage.php Relates to app/Mage.php phpstan labels Dec 23, 2022
@sreichel sreichel requested a review from addison74 December 23, 2022 20:11
@sreichel sreichel merged commit 50418cd into OpenMage:1.9.4.x Dec 23, 2022
@sreichel sreichel deleted the phpstan/daily-1 branch December 23, 2022 20:49
@fballiano fballiano mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addison74 addison74 addison74 approved these changes

+1 more reviewer

@fballiano fballiano fballiano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Mage.php Relates to app/Mage.php phpstan

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sreichel @fballiano @addison74