Skip to content

Cast types, ref #735 #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2022
Merged

Cast types, ref #735 #2872

merged 1 commit into from
Dec 31, 2022

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 31, 2022 •
edited
Loading

Description (*)

Use (int) instead of intval(), (float) ...

Instead of doing this manually (again 👀 ) i tried rector with some basic rules (wip - not all rules applied in this PR).

Related Pull Requests

  1. See Cast types instead of function #735

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Admin Relates to Mage_Admin Component: Api PageRelates to Mage_Api Component: Authorizenet Relates to Mage_Authorizenet Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: lib/Varien Relates to lib/Varien Component: lib/Mage Relates to lib/Mage Component: lib/* Relates to lib/* Component: Log Relates to Mage_Log Component: Page Relates to Mage_Page Component: PayPal Relates to Mage_Paypal Component: Poll Relates to Mage_Poll Component: Rating Relates to Mage_Rating Component: Review Relates to Mage_Review Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa labels Dec 31, 2022
@sreichel sreichel changed the title rector: cast types, ref #735 Cast types, ref #735 Dec 31, 2022
fballiano
fballiano approved these changes Dec 31, 2022
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read almost every line and LGTM

@fballiano fballiano merged commit a5ae514 into OpenMage:1.9.4.x Dec 31, 2022
@sreichel sreichel deleted the rector-0 branch December 31, 2022 17:24
@elidrissidev elidrissidev mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addison74 addison74 addison74 approved these changes

+1 more reviewer

@fballiano fballiano fballiano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Authorizenet Relates to Mage_Authorizenet Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: lib/Mage Relates to lib/Mage Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Log Relates to Mage_Log Component: Page Relates to Mage_Page Component: PayPal Relates to Mage_Paypal Component: Poll Relates to Mage_Poll Component: Rating Relates to Mage_Rating Component: Review Relates to Mage_Review Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sreichel @fballiano @addison74