Remove version check from api.php, get.php, index.php, install.php #2986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fballiano
approved these changes
Jan 20, 2023
luigifab
approved these changes
Jan 20, 2023
|
merged and v20ed |
fballiano
pushed a commit
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Composer autoloader already checks PHP versions, and we will build new releases with the release builder. So, the version check is not needed. See related pull request for more info.
Related Pull Requests
#2982
Questions or comments
We need to bump the minimum supported version to 7.4.0
Contribution checklist (*)