Hotfix: core_store.store_id can be null
#4330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreichel
changed the title
core_store.store_id can be nullcore_store.store_id can be null
github-actions
bot
added
Component: Core
kiatng
approved these changes
Nov 4, 2024
addison74
approved these changes
Nov 6, 2024
fballiano
added a commit
to MahoCommerce/maho
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
I made an error in ... that changes core_store table when creating a new storeview and break whole backend/store.
https://github.com/OpenMage/magento-lts/blob/main/app/code/core/Mage/Core/Model/Store.php#L699-L707
Related Pull Requests
Manual testing scenarios (*)