Feature: Extend Swagger Coverage for controller OAuth2SummitsEventTypesApiController #425
+600
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarcet
reviewed
Nov 6, 2025
| new OA\Response( | ||
| response: Response::HTTP_OK, | ||
| description: "Event types retrieved successfully", | ||
| content: new OA\JsonContent( |
Collaborator
There was a problem hiding this comment.
@andrestejerina97 this should be defined as a new schema at EventTypeSchemas.php as
PaginatedEventTypesResponse ( check
summit-api/app/Swagger/schemas.php
Line 74 in abbde7c
smarcet
reviewed
Nov 6, 2025
| ], | ||
| requestBody: new OA\RequestBody( | ||
| required: true, | ||
| content: new OA\JsonContent( |
Collaborator
There was a problem hiding this comment.
@andrestejerina97 define this as schema here app/Swagger/EventTypeSchemas.php
smarcet
reviewed
Nov 6, 2025
| ], | ||
| requestBody: new OA\RequestBody( | ||
| required: true, | ||
| content: new OA\JsonContent( |
Collaborator
There was a problem hiding this comment.
@andrestejerina97 define this as schema here app/Swagger/EventTypeSchemas.php
smarcet
reviewed
Nov 6, 2025
| new OA\Response( | ||
| response: Response::HTTP_CREATED, | ||
| description: "Default event types seeded successfully", | ||
| content: new OA\JsonContent( |
Collaborator
There was a problem hiding this comment.
smarcet
requested changes
Nov 6, 2025
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@andrestejerina97 please review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b6wkha7