Cairo: Update directory structure #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I feel like I've asked this already (if so, sorry) but do we have automated testing that the output compiles? I can't keep up with the changes in the library so I don't know if these changes are good. It would be great to be able to delegate that concern to automated tests. |
Member
Author
|
We don't yet, but I manually test compilation using the targeted version of the library (with all options enabled for each contract kind). Opened an issue to add automated tests. |
frangio
approved these changes
Jul 28, 2022
Merged
Merged
This was referenced Sep 9, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update directory structure based on OpenZeppelin/cairo-contracts#350
Part of #146
Note: this PR targets the
cairo/nextbranch (which will be merged tomasterupon the next release of Contracts for Cairo).