Add return tokenId (and adjust type) if incremental safeMint #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoveMB
force-pushed
the
212-safeMint-return-tokenId
branch
2 times, most recently
from
08af3b3 to
9e37422
Compare
CoveMB
force-pushed
the
212-safeMint-return-tokenId
branch
from
9e37422 to
e8278fd
Compare
ericglau
approved these changes
Feb 21, 2025
Member
ericglau
left a comment
ericglau
left a comment
There was a problem hiding this comment.
LGTM, thanks! Can you add an entry to the changelog in packages/core/solidity/CHANGELOG.md?
This was referenced Apr 25, 2025
Merged
This was referenced May 11, 2025
This was referenced May 21, 2025
Merged
Merged
Closed
This was referenced Oct 29, 2025
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add return tokenId and and adjust to return type to uint256 if incremental safeMint, if incremental safeMint
Fixes #212