Skip to content

Conversation

@ericglau
Copy link
Member

No description provided.

@ericglau ericglau marked this pull request as ready for review April 28, 2025 20:40
@ericglau ericglau requested a review from CoveMB April 28, 2025 21:09
@socket-security
Copy link

socket-security bot commented May 2, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@ericglau ericglau requested a review from tirumerla May 2, 2025 13:41
@tirumerla tirumerla requested a review from collins-w May 2, 2025 18:45
Copy link
Collaborator

@tirumerla tirumerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor comments

concurrency:
group: validate-cairo-alpha-${{ github.ref }}
cancel-in-progress: true

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You can probably combine cairo-alpha-project and cairo-project into single composite action and use inputs to differentiate? Something to improve upon later

publish: npm run publish
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually for improvements we can pass in provenance uploads using NPM_CONFIG_PROVENANCE: true

@ericglau ericglau merged commit 65f6c25 into OpenZeppelin:master May 2, 2025
16 checks passed
@ericglau ericglau deleted the changesets branch May 2, 2025 20:31
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants