-
Notifications
You must be signed in to change notification settings - Fork 183
Use onlyGovernance to restrict upgrades for Governor with UUPS
#544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ericglau I was having some conflict in the previous PR so I had to close it. Here is a new PR where the master branch is up to date. Please review and let me know if I need to change anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I've added a comment where a refactor would be useful.
- Please add a changeset according to steps in https://github.com/OpenZeppelin/contracts-wizard/blob/master/CONTRIBUTING.md#adding-changesets
…mon logic into helper functions for improved code clarity and maintainability.
|
@ericglau Could you kindly check if everything is alright now? |
onlyGovernance to restrict upgrades for Governor with UUPS
ericglau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. I pushed some refactors and fixed the tests. We'll do some additional reviews before merging.
CoveMB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing
This pull request addresses issue #144 by modifying the Governor contract to utilize the onlyGovernance modifier for the _authorizeUpgrade function when the contract is set as UUPS upgradeable.
Changes Made:
Fixes #144