Add onlyEntryPointOrSelf modifer to multisig #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoveMB
reviewed
May 20, 2025
Contributor
CoveMB
left a comment
CoveMB
left a comment
There was a problem hiding this comment.
Is there a specific set of ok/fail tests that could be added?
Member
Author
|
I think those are the snapshot tests, it's just difficult to get it at first when reviewing hundreds of combinations 😂 |
ericglau
approved these changes
May 20, 2025
Member
ericglau
left a comment
ericglau
left a comment
There was a problem hiding this comment.
LGTM, but this should have a changeset since the previous account functionality was already released.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing modifers to multisigs