Skip to content

Conversation

@CoveMB
Copy link
Contributor

@CoveMB CoveMB commented Jun 6, 2025

Fixes #440 (for Stellar only)

  • Add input UI component to capture security info
  • Update info type for Stellar
  • Add security info for AI agent
  • Add contract documentation for Stellar contract builder
  • Add print of contract documentation ( here security info) for Stellar
  • Add test for printing documentation

// Compatible with OpenZeppelin Stellar Soroban Contracts ^0.2.0␊
#![no_std]␊
/// @custom:security-contact [email protected]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brozorec @ozgunozerk Would this be the appropriate placement for the security contact comment (and possibly other contract level comments)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following our docstring practice, I suggest this goes like so:

/// SPDX-License-Identifier: MIT␊
/// Security Contact: [email protected]␊
/// Compatible with OpenZeppelin Stellar Soroban Contracts ^0.2.0␊
#![no_std]␊

// Compatible with OpenZeppelin Stellar Soroban Contracts ^0.2.0␊
#![no_std]␊
/// @custom:security-contact [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following our docstring practice, I suggest this goes like so:

/// SPDX-License-Identifier: MIT␊
/// Security Contact: [email protected]␊
/// Compatible with OpenZeppelin Stellar Soroban Contracts ^0.2.0␊
#![no_std]␊

@CoveMB
Copy link
Contributor Author

CoveMB commented Jun 23, 2025

@brozorec do you think of any further modification?

@brozorec
Copy link
Contributor

@brozorec do you think of any further modification?

LGTM, thank you @CoveMB 🙏

@CoveMB
Copy link
Contributor Author

CoveMB commented Jun 25, 2025

Thanks to you for the guidance 🙏
(could you lift the "require changes" status?)

@CoveMB CoveMB merged commit 8997a89 into OpenZeppelin:master Jun 26, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cairo: Add security contact field

3 participants