-
Notifications
You must be signed in to change notification settings - Fork 183
Stellar add security contract field #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stellar add security contract field #563
Conversation
Co-authored-by: Eric Lau <[email protected]>
| // Compatible with OpenZeppelin Stellar Soroban Contracts ^0.2.0␊ | ||
| #![no_std]␊ | ||
| ␊ | ||
| /// @custom:security-contact [email protected]␊ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brozorec @ozgunozerk Would this be the appropriate placement for the security contact comment (and possibly other contract level comments)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following our docstring practice, I suggest this goes like so:
/// SPDX-License-Identifier: MIT␊
/// Security Contact: [email protected]␊
/// Compatible with OpenZeppelin Stellar Soroban Contracts ^0.2.0␊
#![no_std]␊
Co-authored-by: Eric Lau <[email protected]>
| // Compatible with OpenZeppelin Stellar Soroban Contracts ^0.2.0␊ | ||
| #![no_std]␊ | ||
| ␊ | ||
| /// @custom:security-contact [email protected]␊ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following our docstring practice, I suggest this goes like so:
/// SPDX-License-Identifier: MIT␊
/// Security Contact: [email protected]␊
/// Compatible with OpenZeppelin Stellar Soroban Contracts ^0.2.0␊
#![no_std]␊
…MB/contracts-wizard into stellar-add-security-contract-field
…ity-contract-field
|
@brozorec do you think of any further modification? |
|
Thanks to you for the guidance 🙏 |
Fixes #440 (for Stellar only)