Skip to content

Conversation

@brozorec
Copy link
Contributor

@brozorec brozorec commented Jun 9, 2025

This PR:

  • renames defaultimpl to default_impl in Non-Fungible
  • adds ContractOverrides to imports in Enumerable

@brozorec brozorec requested a review from ozgunozerk June 9, 2025 12:10
@brozorec brozorec requested a review from ericglau June 9, 2025 12:50
@brozorec brozorec marked this pull request as ready for review June 9, 2025 12:50
@ericglau ericglau requested a review from CoveMB June 9, 2025 15:05
Copy link
Contributor

@CoveMB CoveMB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, we can consider adding compilation tests so we can test the compilation of all different combination.

I started here we could replace running test with simply running cargo build and also catch warnings

@brozorec
Copy link
Contributor Author

Sounds good, we can consider adding compilation tests so we can test the compilation of all different combination.

I started here we could replace running test with simply running cargo build and also catch warnings

That's great, it would've def caught those issues.

@brozorec brozorec requested a review from ericglau June 10, 2025 10:12
@brozorec brozorec merged commit 1b5551e into OpenZeppelin:master Jun 10, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants